perf: arm_cspmu: Set irq affinitiy only if overflow interrupt is used

ilkka-koskinen · willdeacon · commit 225d757012e0 · 2023-06-09T11:25:56.000+01:00
Don't try to set irq affinity if PMU doesn't have an overflow interrupt. Fixes: e37dfd6 ("perf: arm_cspmu: Add support for ARM CoreSight PMU driver") Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> Link: https://lore.kernel.org/r/20230608203742.3503486-1-ilkka@os.amperecomputing.com Signed-off-by: Will Deacon <will@kernel.org>
diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
@@ -1232,7 +1232,8 @@ static struct platform_driver arm_cspmu_driver = {
 static void arm_cspmu_set_active_cpu(int cpu, struct arm_cspmu *cspmu)
 {
 	cpumask_set_cpu(cpu, &cspmu->active_cpu);
-	WARN_ON(irq_set_affinity(cspmu->irq, &cspmu->active_cpu));
+	if (cspmu->irq)
+		WARN_ON(irq_set_affinity(cspmu->irq, &cspmu->active_cpu));
 }
 
 static int arm_cspmu_cpu_online(unsigned int cpu, struct hlist_node *node)

Original file line number	Diff line number	Diff line change
`@@ -1232,7 +1232,8 @@ static struct platform_driver arm_cspmu_driver = {`
`1232`	`1232`	`static void arm_cspmu_set_active_cpu(int cpu, struct arm_cspmu *cspmu)`
`1233`	`1233`	`{`
`1234`	`1234`	`cpumask_set_cpu(cpu, &cspmu->active_cpu);`
`1235`		`- WARN_ON(irq_set_affinity(cspmu->irq, &cspmu->active_cpu));`
	`1235`	`+ if (cspmu->irq)`
	`1236`	`+ WARN_ON(irq_set_affinity(cspmu->irq, &cspmu->active_cpu));`
`1236`	`1237`	`}`
`1237`	`1238`
`1238`	`1239`	`static int arm_cspmu_cpu_online(unsigned int cpu, struct hlist_node *node)`