Skip to content

Commit 22eb23b

Browse files
committed
fs: remove useless lockdep assertion
mnt_ns_release() can run asynchronously via call_rcu() so hitting that lockdep assertion means someone else already grabbed the mnt_ns_tree_lock and causes a false positive. That assertion has likely always been wrong. call_rcu() just makes it more likely to hit. Link: https://lore.kernel.org/r/Z2PlT5rcRTIhCpft@ly-workstation Link: https://lore.kernel.org/r/20241219-darben-quietschen-b6e1d80327bb@brauner Reported-by: Lai, Yi <[email protected]> Signed-off-by: Christian Brauner <[email protected]>
1 parent 7f9bfaf commit 22eb23b

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

fs/namespace.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,6 @@ static void mnt_ns_tree_add(struct mnt_namespace *ns)
160160

161161
static void mnt_ns_release(struct mnt_namespace *ns)
162162
{
163-
lockdep_assert_not_held(&mnt_ns_tree_lock.lock);
164-
165163
/* keep alive for {list,stat}mount() */
166164
if (refcount_dec_and_test(&ns->passive)) {
167165
put_user_ns(ns->user_ns);

0 commit comments

Comments
 (0)