Skip to content

Commit 233679b

Browse files
yghannambp3tk0v
authored andcommitted
RAS/AMD/ATL: Add debug prints for DF register reads
The ATL will fail early if the DF register access fails due to missing PCI IDs in the amd_nb code. There aren't any clear indicators on why the ATL will fail to load in this case. Add a couple of debug print statements to highlight reasons for failure. A common scenario is missing support for new hardware. If the ATL fails to load on a system, and there is interest to support it, then dynamic debugging can be enabled to help find the cause for failure. If there is no interest in supporting ATL on a new system, then these failures will be silent. Signed-off-by: Yazen Ghannam <[email protected]> Signed-off-by: Borislav Petkov (AMD) <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent e419675 commit 233679b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/ras/amd/atl/access.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,16 @@ static int __df_indirect_read(u16 node, u8 func, u16 reg, u8 instance_id, u32 *l
7070
u32 ficaa = 0;
7171

7272
node = get_accessible_node(node);
73-
if (node >= amd_nb_num())
73+
if (node >= amd_nb_num()) {
74+
pr_debug("Node %u is out of bounds\n", node);
7475
goto out;
76+
}
7577

7678
F4 = node_to_amd_nb(node)->link;
77-
if (!F4)
79+
if (!F4) {
80+
pr_debug("DF function 4 not found\n");
7881
goto out;
82+
}
7983

8084
/* Enable instance-specific access. */
8185
if (instance_id != DF_BROADCAST) {

0 commit comments

Comments
 (0)