Skip to content

Commit 2380dd6

Browse files
committed
Merge branch 'pcmcia-next' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux
Pull pcmcia updates from Dominik Brodowski: "A few odd cleanups and fixes, including a Kconfig fix to add a required dependency on MIPS" * 'pcmcia-next' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux: pcmcia: Use platform_get_irq() to get the interrupt pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards drivers/pcmcia: Fix typo in comment
2 parents 700170b + 2ef4bb2 commit 2380dd6

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

drivers/pcmcia/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ config TCIC
151151

152152
config PCMCIA_ALCHEMY_DEVBOARD
153153
tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
154-
depends on MIPS_ALCHEMY && PCMCIA
154+
depends on MIPS_DB1XXX && PCMCIA
155155
help
156156
Enable this driver of you want PCMCIA support on your Alchemy
157157
Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300

drivers/pcmcia/bcm63xx_pcmcia.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,10 +327,11 @@ static int bcm63xx_drv_pcmcia_probe(struct platform_device *pdev)
327327
{
328328
struct bcm63xx_pcmcia_socket *skt;
329329
struct pcmcia_socket *sock;
330-
struct resource *res, *irq_res;
330+
struct resource *res;
331331
unsigned int regmem_size = 0, iomem_size = 0;
332332
u32 val;
333333
int ret;
334+
int irq;
334335

335336
skt = kzalloc(sizeof(*skt), GFP_KERNEL);
336337
if (!skt)
@@ -342,9 +343,9 @@ static int bcm63xx_drv_pcmcia_probe(struct platform_device *pdev)
342343
/* make sure we have all resources we need */
343344
skt->common_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
344345
skt->attr_res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
345-
irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
346+
irq = platform_get_irq(pdev, 0);
346347
skt->pd = pdev->dev.platform_data;
347-
if (!skt->common_res || !skt->attr_res || !irq_res || !skt->pd) {
348+
if (!skt->common_res || !skt->attr_res || (irq < 0) || !skt->pd) {
348349
ret = -EINVAL;
349350
goto err;
350351
}
@@ -380,7 +381,7 @@ static int bcm63xx_drv_pcmcia_probe(struct platform_device *pdev)
380381
sock->dev.parent = &pdev->dev;
381382
sock->features = SS_CAP_STATIC_MAP | SS_CAP_PCCARD;
382383
sock->io_offset = (unsigned long)skt->io_base;
383-
sock->pci_irq = irq_res->start;
384+
sock->pci_irq = irq;
384385

385386
#ifdef CONFIG_CARDBUS
386387
sock->cb_dev = bcm63xx_cb_dev;

drivers/pcmcia/rsrc_nonstatic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ static int do_validate_mem(struct pcmcia_socket *s,
394394
* do_mem_probe() checks a memory region for use by the PCMCIA subsystem.
395395
* To do so, the area is split up into sensible parts, and then passed
396396
* into the @validate() function. Only if @validate() and @fallback() fail,
397-
* the area is marked as unavaibale for use by the PCMCIA subsystem. The
397+
* the area is marked as unavailable for use by the PCMCIA subsystem. The
398398
* function returns the size of the usable memory area.
399399
*/
400400
static int do_mem_probe(struct pcmcia_socket *s, u_long base, u_long num,

0 commit comments

Comments
 (0)