Skip to content

Commit 238d77d

Browse files
johndale88kuba-moo
authored andcommitted
enic: Obtain the Link speed only after the link comes up
The link speed is obtained in the RX adaptive coalescing function. It was being called at probe time when the link may not be up. Change the call to run after the Link comes up. The impact of not getting the correct link speed was that the low end of the adaptive interrupt range was always being set to 0 which could have caused a slight increase in the number of RX interrupts. Co-developed-by: Nelson Escobar <[email protected]> Signed-off-by: Nelson Escobar <[email protected]> Co-developed-by: Satish Kharat <[email protected]> Signed-off-by: Satish Kharat <[email protected]> Signed-off-by: John Daley <[email protected]> Reviewed-by: Kalesh AP <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent af2ccc6 commit 238d77d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/cisco/enic/enic_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,6 +466,7 @@ static void enic_link_check(struct enic *enic)
466466
if (link_status && !carrier_ok) {
467467
netdev_info(enic->netdev, "Link UP\n");
468468
netif_carrier_on(enic->netdev);
469+
enic_set_rx_coal_setting(enic);
469470
} else if (!link_status && carrier_ok) {
470471
netdev_info(enic->netdev, "Link DOWN\n");
471472
netif_carrier_off(enic->netdev);
@@ -3063,7 +3064,6 @@ static int enic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
30633064
timer_setup(&enic->notify_timer, enic_notify_timer, 0);
30643065

30653066
enic_rfs_flw_tbl_init(enic);
3066-
enic_set_rx_coal_setting(enic);
30673067
INIT_WORK(&enic->reset, enic_reset);
30683068
INIT_WORK(&enic->tx_hang_reset, enic_tx_hang_reset);
30693069
INIT_WORK(&enic->change_mtu_work, enic_change_mtu_work);

0 commit comments

Comments
 (0)