Skip to content

Commit 23a653e

Browse files
GustavoARSilvabroonie
authored andcommitted
regulator: da9063: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertenly introduced[3] to the codebase from now on. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]> Link: https://lore.kernel.org/r/20200211234710.GA29532@embeddedor Signed-off-by: Mark Brown <[email protected]>
1 parent c1e1fa0 commit 23a653e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/regulator/da9063-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ struct da9063_regulator {
152152
struct da9063_regulators {
153153
unsigned int n_regulators;
154154
/* Array size to be defined during init. Keep at end. */
155-
struct da9063_regulator regulator[0];
155+
struct da9063_regulator regulator[];
156156
};
157157

158158
/* BUCK modes for DA9063 */

0 commit comments

Comments
 (0)