Skip to content

Commit 23b2c96

Browse files
Christian Braunerkees
authored andcommitted
seccomp: rework define for SECCOMP_USER_NOTIF_FLAG_CONTINUE
Switch from BIT(0) to (1UL << 0). First, there are already two different forms used in the header, so there's no need to add a third. Second, the BIT() macros is kernel internal and afaict not actually exposed to userspace. Maybe there's some magic there I'm missing but it definitely causes issues when compiling a program that tries to use SECCOMP_USER_NOTIF_FLAG_CONTINUE. It currently fails in the following way: # github.com/lxc/lxd/lxd /usr/bin/ld: $WORK/b001/_x003.o: in function `__do_user_notification_continue': lxd/main_checkfeature.go:240: undefined reference to `BIT' collect2: error: ld returned 1 exit status Switching to (1UL << 0) should prevent that and is more in line what is already done in the rest of the header. Cc: Kees Cook <[email protected]> Cc: Andy Lutomirski <[email protected]> Signed-off-by: Christian Brauner <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kees Cook <[email protected]>
1 parent 2aa8d8d commit 23b2c96

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/uapi/linux/seccomp.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ struct seccomp_notif {
103103
* SECCOMP_USER_NOTIF_FLAG_CONTINUE. Note that SECCOMP_RET_TRACE can equally
104104
* be overriden by SECCOMP_USER_NOTIF_FLAG_CONTINUE.
105105
*/
106-
#define SECCOMP_USER_NOTIF_FLAG_CONTINUE BIT(0)
106+
#define SECCOMP_USER_NOTIF_FLAG_CONTINUE (1UL << 0)
107107

108108
struct seccomp_notif_resp {
109109
__u64 id;

0 commit comments

Comments
 (0)