Skip to content

Commit 23ec111

Browse files
norbertx-zulinskianguy11
authored andcommitted
i40e: Fix NULL pointer dereference in i40e_dbg_dump_desc
When trying to dump VFs VSI RX/TX descriptors using debugfs there was a crash due to NULL pointer dereference in i40e_dbg_dump_desc. Added a check to i40e_dbg_dump_desc that checks if VSI type is correct for dumping RX/TX descriptors. Fixes: 02e9c29 ("i40e: debugfs interface") Signed-off-by: Sylwester Dziedziuch <[email protected]> Signed-off-by: Norbert Zulinski <[email protected]> Signed-off-by: Mateusz Palczewski <[email protected]> Tested-by: Gurucharan G <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 8aa55ab commit 23ec111

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,14 @@ static void i40e_dbg_dump_desc(int cnt, int vsi_seid, int ring_id, int desc_n,
553553
dev_info(&pf->pdev->dev, "vsi %d not found\n", vsi_seid);
554554
return;
555555
}
556+
if (vsi->type != I40E_VSI_MAIN &&
557+
vsi->type != I40E_VSI_FDIR &&
558+
vsi->type != I40E_VSI_VMDQ2) {
559+
dev_info(&pf->pdev->dev,
560+
"vsi %d type %d descriptor rings not available\n",
561+
vsi_seid, vsi->type);
562+
return;
563+
}
556564
if (type == RING_TYPE_XDP && !i40e_enabled_xdp_vsi(vsi)) {
557565
dev_info(&pf->pdev->dev, "XDP not enabled on VSI %d\n", vsi_seid);
558566
return;

0 commit comments

Comments
 (0)