Skip to content

Commit 23ef63d

Browse files
author
Damien Le Moal
committed
ata: libata: improve ata_read_log_page() error message
If ata_read_log_page() fails to read a log page, the ata_dev_err() error message only print the page number, omitting the log number. In case of error, facilitate debugging by also printing the log number. Cc: [email protected] # 5.15 Signed-off-by: Damien Le Moal <[email protected]> Tested-by: Matthew Perkowski <[email protected]>
1 parent fa55b7d commit 23ef63d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/ata/libata-core.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2031,8 +2031,9 @@ unsigned int ata_read_log_page(struct ata_device *dev, u8 log,
20312031
dev->horkage |= ATA_HORKAGE_NO_DMA_LOG;
20322032
goto retry;
20332033
}
2034-
ata_dev_err(dev, "Read log page 0x%02x failed, Emask 0x%x\n",
2035-
(unsigned int)page, err_mask);
2034+
ata_dev_err(dev,
2035+
"Read log 0x%02x page 0x%02x failed, Emask 0x%x\n",
2036+
(unsigned int)log, (unsigned int)page, err_mask);
20362037
}
20372038

20382039
return err_mask;

0 commit comments

Comments
 (0)