Skip to content

Commit 253b3c4

Browse files
author
Vasily Gorbik
committed
s390: adjust -mpacked-stack support check for clang 10
clang 10 introduces -mpacked-stack compiler option implementation. At the same time currently it does not support a combination of -mpacked-stack and -mbackchain. This leads to the following build error: clang: error: unsupported option '-mpacked-stack with -mbackchain' for target 's390x-ibm-linux' If/when clang adds support for a combination of -mpacked-stack and -mbackchain it would also require -msoft-float (like gcc does). According to Ulrich Weigand "stack slot assigned to the kernel backchain overlaps the stack slot assigned to the FPR varargs (both are required to be placed immediately after the saved r15 slot if present)." Extend -mpacked-stack compiler option support check to include all 3 options -mpacked-stack -mbackchain -msoft-float which must present to support -mpacked-stack with -mbackchain. Acked-by: Heiko Carstens <[email protected]> Signed-off-by: Vasily Gorbik <[email protected]>
1 parent c4e5c22 commit 253b3c4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/s390/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ cflags-y += -Wa,-I$(srctree)/arch/$(ARCH)/include
6969
#
7070
cflags-$(CONFIG_FRAME_POINTER) += -fno-optimize-sibling-calls
7171

72-
ifeq ($(call cc-option-yn,-mpacked-stack),y)
72+
ifeq ($(call cc-option-yn,-mpacked-stack -mbackchain -msoft-float),y)
7373
cflags-$(CONFIG_PACK_STACK) += -mpacked-stack -D__PACK_STACK
7474
aflags-$(CONFIG_PACK_STACK) += -D__PACK_STACK
7575
endif

0 commit comments

Comments
 (0)