Skip to content

Commit 256df20

Browse files
superm1bjorn-helgaas
authored andcommitted
PCI/PM: Avoid D3cold for HP Pavilion 17 PC/1972 PCIe Ports
Hewlett-Packard HP Pavilion 17 Notebook PC/1972 is an Intel Ivy Bridge system with a muxless AMD Radeon dGPU. Attempting to use the dGPU fails with the following sequence: ACPI Error: Aborting method \AMD3._ON due to previous error (AE_AML_LOOP_TIMEOUT) (20230628/psparse-529) radeon 0000:01:00.0: not ready 1023ms after resume; waiting radeon 0000:01:00.0: not ready 2047ms after resume; waiting radeon 0000:01:00.0: not ready 4095ms after resume; waiting radeon 0000:01:00.0: not ready 8191ms after resume; waiting radeon 0000:01:00.0: not ready 16383ms after resume; waiting radeon 0000:01:00.0: not ready 32767ms after resume; waiting radeon 0000:01:00.0: not ready 65535ms after resume; giving up radeon 0000:01:00.0: Unable to change power state from D3cold to D0, device inaccessible The issue is that the Root Port the dGPU is connected to can't handle the transition from D3cold to D0 so the dGPU can't properly exit runtime PM. The existing logic in pci_bridge_d3_possible() checks for systems that are newer than 2015 to decide that D3 is safe. This would nominally work for an Ivy Bridge system (which was discontinued in 2015), but this system appears to have continued to receive BIOS updates until 2017 and so this existing logic doesn't appropriately capture it. Add the system to bridge_d3_blacklist to prevent D3cold from being used. Link: https://lore.kernel.org/r/[email protected] Reported-by: Eric Heintzmann <[email protected]> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3229 Signed-off-by: Mario Limonciello <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Tested-by: Eric Heintzmann <[email protected]>
1 parent 4cece76 commit 256df20

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

drivers/pci/pci.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2962,6 +2962,18 @@ static const struct dmi_system_id bridge_d3_blacklist[] = {
29622962
DMI_MATCH(DMI_BOARD_VERSION, "Continental Z2"),
29632963
},
29642964
},
2965+
{
2966+
/*
2967+
* Changing power state of root port dGPU is connected fails
2968+
* https://gitlab.freedesktop.org/drm/amd/-/issues/3229
2969+
*/
2970+
.ident = "Hewlett-Packard HP Pavilion 17 Notebook PC/1972",
2971+
.matches = {
2972+
DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
2973+
DMI_MATCH(DMI_BOARD_NAME, "1972"),
2974+
DMI_MATCH(DMI_BOARD_VERSION, "95.33"),
2975+
},
2976+
},
29652977
#endif
29662978
{ }
29672979
};

0 commit comments

Comments
 (0)