Skip to content

Commit 257e03a

Browse files
Kobatwandy-shev
authored andcommitted
platform/x86: dell-laptop: don't register micmute LED if there is no token
On Dell G3-3590, error message is issued during boot up, "platform::micmute: Setting an LED's brightness failed (-19)", but there's no micmute led on the machine. Get the related tokens of SMBIOS, GLOBAL_MIC_MUTE_DISABLE/ENABLE. If one of two tokens doesn't exist, don't call led_classdev_register() for platform::micmute. After that, you wouldn't see the platform::micmute in /sys/class/leds/, and the error message wouldn't see in dmesg. Fixes: d00fa46 ("platform/x86: dell-laptop: Add micmute LED trigger support") Signed-off-by: Koba Ko <[email protected]> Reviewed-by: Mario Limonciello <[email protected]> Reviewed-by: Pali Rohár <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
1 parent 466f469 commit 257e03a

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

drivers/platform/x86/dell-laptop.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2204,10 +2204,13 @@ static int __init dell_init(void)
22042204

22052205
dell_laptop_register_notifier(&dell_laptop_notifier);
22062206

2207-
micmute_led_cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
2208-
ret = led_classdev_register(&platform_device->dev, &micmute_led_cdev);
2209-
if (ret < 0)
2210-
goto fail_led;
2207+
if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&
2208+
dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) {
2209+
micmute_led_cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
2210+
ret = led_classdev_register(&platform_device->dev, &micmute_led_cdev);
2211+
if (ret < 0)
2212+
goto fail_led;
2213+
}
22112214

22122215
if (acpi_video_get_backlight_type() != acpi_backlight_vendor)
22132216
return 0;

0 commit comments

Comments
 (0)