Skip to content

Commit 25b5476

Browse files
frankjaaborntraeger
authored andcommitted
KVM: s390: Function documentation fixes
The latest compile changes pointed us to a few instances where we use the kernel documentation style but don't explain all variables or don't adhere to it 100%. It's easy to fix so let's do that. Signed-off-by: Janosch Frank <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
1 parent 5c49d18 commit 25b5476

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

arch/s390/kvm/gaccess.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -894,6 +894,11 @@ int access_guest_real(struct kvm_vcpu *vcpu, unsigned long gra,
894894

895895
/**
896896
* guest_translate_address - translate guest logical into guest absolute address
897+
* @vcpu: virtual cpu
898+
* @gva: Guest virtual address
899+
* @ar: Access register
900+
* @gpa: Guest physical address
901+
* @mode: Translation access mode
897902
*
898903
* Parameter semantics are the same as the ones from guest_translate.
899904
* The memory contents at the guest address are not changed.
@@ -934,6 +939,11 @@ int guest_translate_address(struct kvm_vcpu *vcpu, unsigned long gva, u8 ar,
934939

935940
/**
936941
* check_gva_range - test a range of guest virtual addresses for accessibility
942+
* @vcpu: virtual cpu
943+
* @gva: Guest virtual address
944+
* @ar: Access register
945+
* @length: Length of test range
946+
* @mode: Translation access mode
937947
*/
938948
int check_gva_range(struct kvm_vcpu *vcpu, unsigned long gva, u8 ar,
939949
unsigned long length, enum gacc_mode mode)
@@ -956,6 +966,7 @@ int check_gva_range(struct kvm_vcpu *vcpu, unsigned long gva, u8 ar,
956966

957967
/**
958968
* kvm_s390_check_low_addr_prot_real - check for low-address protection
969+
* @vcpu: virtual cpu
959970
* @gra: Guest real address
960971
*
961972
* Checks whether an address is subject to low-address protection and set
@@ -979,6 +990,7 @@ int kvm_s390_check_low_addr_prot_real(struct kvm_vcpu *vcpu, unsigned long gra)
979990
* @pgt: pointer to the beginning of the page table for the given address if
980991
* successful (return value 0), or to the first invalid DAT entry in
981992
* case of exceptions (return value > 0)
993+
* @dat_protection: referenced memory is write protected
982994
* @fake: pgt references contiguous guest memory block, not a pgtable
983995
*/
984996
static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,

arch/s390/kvm/intercept.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ static int handle_prog(struct kvm_vcpu *vcpu)
269269

270270
/**
271271
* handle_external_interrupt - used for external interruption interceptions
272+
* @vcpu: virtual cpu
272273
*
273274
* This interception only occurs if the CPUSTAT_EXT_INT bit was set, or if
274275
* the new PSW does not have external interrupts disabled. In the first case,
@@ -315,7 +316,8 @@ static int handle_external_interrupt(struct kvm_vcpu *vcpu)
315316
}
316317

317318
/**
318-
* Handle MOVE PAGE partial execution interception.
319+
* handle_mvpg_pei - Handle MOVE PAGE partial execution interception.
320+
* @vcpu: virtual cpu
319321
*
320322
* This interception can only happen for guests with DAT disabled and
321323
* addresses that are currently not mapped in the host. Thus we try to

0 commit comments

Comments
 (0)