Skip to content

Commit 25d3872

Browse files
kimphillamdIngo Molnar
authored andcommitted
perf/x86/amd: Add missing L2 misses event spec to AMD Family 17h's event map
Commit 3fe3331 ("perf/x86/amd: Add event map for AMD Family 17h"), claimed L2 misses were unsupported, due to them not being found in its referenced documentation, whose link has now moved [1]. That old documentation listed PMCx064 unit mask bit 3 as: "LsRdBlkC: LS Read Block C S L X Change to X Miss." and bit 0 as: "IcFillMiss: IC Fill Miss" We now have new public documentation [2] with improved descriptions, that clearly indicate what events those unit mask bits represent: Bit 3 now clearly states: "LsRdBlkC: Data Cache Req Miss in L2 (all types)" and bit 0 is: "IcFillMiss: Instruction Cache Req Miss in L2." So we can now add support for L2 misses in perf's genericised events as PMCx064 with both the above unit masks. [1] The commit's original documentation reference, "Processor Programming Reference (PPR) for AMD Family 17h Model 01h, Revision B1 Processors", originally available here: https://www.amd.com/system/files/TechDocs/54945_PPR_Family_17h_Models_00h-0Fh.pdf is now available here: https://developer.amd.com/wordpress/media/2017/11/54945_PPR_Family_17h_Models_00h-0Fh.pdf [2] "Processor Programming Reference (PPR) for Family 17h Model 31h, Revision B0 Processors", available here: https://developer.amd.com/wp-content/resources/55803_0.54-PUB.pdf Fixes: 3fe3331 ("perf/x86/amd: Add event map for AMD Family 17h") Reported-by: Babu Moger <[email protected]> Signed-off-by: Kim Phillips <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Tested-by: Babu Moger <[email protected]> Cc: [email protected] Link: https://lkml.kernel.org/r/[email protected]
1 parent 0aa0e0d commit 25d3872

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

arch/x86/events/amd/core.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@ static const u64 amd_f17h_perfmon_event_map[PERF_COUNT_HW_MAX] =
250250
[PERF_COUNT_HW_CPU_CYCLES] = 0x0076,
251251
[PERF_COUNT_HW_INSTRUCTIONS] = 0x00c0,
252252
[PERF_COUNT_HW_CACHE_REFERENCES] = 0xff60,
253+
[PERF_COUNT_HW_CACHE_MISSES] = 0x0964,
253254
[PERF_COUNT_HW_BRANCH_INSTRUCTIONS] = 0x00c2,
254255
[PERF_COUNT_HW_BRANCH_MISSES] = 0x00c3,
255256
[PERF_COUNT_HW_STALLED_CYCLES_FRONTEND] = 0x0287,

0 commit comments

Comments
 (0)