Skip to content

Commit 25d7070

Browse files
nfrapradoPaolo Abeni
authored andcommitted
net: stmmac: Fix unbalanced IRQ wake disable warning on single irq case
Commit a23aa04 ("net: stmmac: ethtool: Fixed calltrace caused by unbalanced disable_irq_wake calls") introduced checks to prevent unbalanced enable and disable IRQ wake calls. However it only initialized the auxiliary variable on one of the paths, stmmac_request_irq_multi_msi(), missing the other, stmmac_request_irq_single(). Add the same initialization on stmmac_request_irq_single() to prevent "Unbalanced IRQ <x> wake disable" warnings from being printed the first time disable_irq_wake() is called on platforms that run on that code path. Fixes: a23aa04 ("net: stmmac: ethtool: Fixed calltrace caused by unbalanced disable_irq_wake calls") Signed-off-by: Nícolas F. R. A. Prado <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/20241101-stmmac-unbalanced-wake-single-fix-v1-1-5952524c97f0@collabora.com Signed-off-by: Paolo Abeni <[email protected]>
1 parent 1f26339 commit 25d7070

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3780,6 +3780,7 @@ static int stmmac_request_irq_single(struct net_device *dev)
37803780
/* Request the Wake IRQ in case of another line
37813781
* is used for WoL
37823782
*/
3783+
priv->wol_irq_disabled = true;
37833784
if (priv->wol_irq > 0 && priv->wol_irq != dev->irq) {
37843785
ret = request_irq(priv->wol_irq, stmmac_interrupt,
37853786
IRQF_SHARED, dev->name, dev);

0 commit comments

Comments
 (0)