Skip to content

Commit 25e5d4d

Browse files
Russell KingAl Viro
authored andcommitted
fs/adfs: mostly divorse inode number from indirect disc address
Avoid using the inode number as the indirect disc address, even though these currently have the same value. Signed-off-by: Russell King <[email protected]> Signed-off-by: Al Viro <[email protected]>
1 parent 08ead1b commit 25e5d4d

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

fs/adfs/adfs.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ static inline u16 adfs_filetype(u32 loadaddr)
3232
struct adfs_inode_info {
3333
loff_t mmu_private;
3434
__u32 parent_id; /* parent indirect disc address */
35+
__u32 indaddr; /* object indirect disc address */
3536
__u32 loadaddr; /* RISC OS load address */
3637
__u32 execaddr; /* RISC OS exec address */
3738
unsigned int attr; /* RISC OS permissions */

fs/adfs/dir.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ static int adfs_dir_read_inode(struct super_block *sb, struct inode *inode,
158158
{
159159
int ret;
160160

161-
ret = adfs_dir_read(sb, inode->i_ino, inode->i_size, dir);
161+
ret = adfs_dir_read(sb, ADFS_I(inode)->indaddr, inode->i_size, dir);
162162
if (ret)
163163
return ret;
164164

@@ -372,7 +372,7 @@ static int adfs_dir_lookup_byname(struct inode *inode, const struct qstr *qstr,
372372
break;
373373
}
374374
}
375-
obj->parent_id = inode->i_ino;
375+
obj->parent_id = ADFS_I(inode)->indaddr;
376376

377377
unlock_relse:
378378
up_read(&adfs_dir_rwsem);

fs/adfs/inode.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ adfs_get_block(struct inode *inode, sector_t block, struct buffer_head *bh,
2020
if (block >= inode->i_blocks)
2121
goto abort_toobig;
2222

23-
block = __adfs_block_map(inode->i_sb, inode->i_ino, block);
23+
block = __adfs_block_map(inode->i_sb, ADFS_I(inode)->indaddr,
24+
block);
2425
if (block)
2526
map_bh(bh, inode->i_sb, block);
2627
return 0;
@@ -259,6 +260,7 @@ adfs_iget(struct super_block *sb, struct object_info *obj)
259260
* for cross-directory renames.
260261
*/
261262
ADFS_I(inode)->parent_id = obj->parent_id;
263+
ADFS_I(inode)->indaddr = obj->indaddr;
262264
ADFS_I(inode)->loadaddr = obj->loadaddr;
263265
ADFS_I(inode)->execaddr = obj->execaddr;
264266
ADFS_I(inode)->attr = obj->attr;
@@ -353,7 +355,7 @@ int adfs_write_inode(struct inode *inode, struct writeback_control *wbc)
353355
struct object_info obj;
354356
int ret;
355357

356-
obj.indaddr = inode->i_ino;
358+
obj.indaddr = ADFS_I(inode)->indaddr;
357359
obj.name_len = 0;
358360
obj.parent_id = ADFS_I(inode)->parent_id;
359361
obj.loadaddr = ADFS_I(inode)->loadaddr;

0 commit comments

Comments
 (0)