Skip to content

Commit 25fb101

Browse files
ojedaJonathan Corbet
authored andcommitted
docs: submitting-patches: clarify difference between Acked-by and Reviewed-by
Newcomers to the kernel need to learn the different tags that are used in commit messages and when to apply them. Acked-by is sometimes misunderstood, since the documentation did not really clarify (up to the previous commit) when it should be used, especially compared to Reviewed-by. The previous commit already clarified who the usual providers of Acked-by tags are, with examples. Thus provide a clarification paragraph for the comparison with Reviewed-by, and give a couple examples reusing the cases given above, in the previous commit. Acked-by: Shuah Khan <[email protected]> Acked-by: Dan Williams <[email protected]> Signed-off-by: Miguel Ojeda <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Acked-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Jonathan Corbet <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent cd9123e commit 25fb101

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

Documentation/process/submitting-patches.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -480,6 +480,12 @@ mergers will sometimes manually convert an acker's "yep, looks good to me"
480480
into an Acked-by: (but note that it is usually better to ask for an
481481
explicit ack).
482482

483+
Acked-by: is also less formal than Reviewed-by:. For instance, maintainers may
484+
use it to signify that they are OK with a patch landing, but they may not have
485+
reviewed it as thoroughly as if a Reviewed-by: was provided. Similarly, a key
486+
user may not have carried out a technical review of the patch, yet they may be
487+
satisfied with the general approach, the feature or the user-facing interface.
488+
483489
Acked-by: does not necessarily indicate acknowledgement of the entire patch.
484490
For example, if a patch affects multiple subsystems and has an Acked-by: from
485491
one subsystem maintainer then this usually indicates acknowledgement of just

0 commit comments

Comments
 (0)