Skip to content

Commit 25fe3d5

Browse files
committed
sev-dev: avoid pointless cred reference count bump
and fix a memory leak while at it. The new creds are created via prepare_creds() and then reverted via put_cred(revert_creds()). The additional reference count bump from override_creds() wasn't even taken into account before. Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Jeff Layton <[email protected]> Reviewed-by: Jens Axboe <[email protected]> Signed-off-by: Christian Brauner <[email protected]>
1 parent 7915f42 commit 25fe3d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/crypto/ccp/sev-dev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ static struct file *open_file_as_root(const char *filename, int flags, umode_t m
244244
if (!cred)
245245
return ERR_PTR(-ENOMEM);
246246
cred->fsuid = GLOBAL_ROOT_UID;
247-
old_cred = override_creds(get_new_cred(cred));
247+
old_cred = override_creds(cred);
248248

249249
fp = file_open_root(&root, filename, flags, mode);
250250
path_put(&root);

0 commit comments

Comments
 (0)