Skip to content

Commit 2650fd8

Browse files
committed
Merge tag 'v6.11-rockchip-dtsfixes' of https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip into arm/fixes
A number of pin fixes for Puma, Rock-Pi-E and rk356x, and as it turns out the VO0 and VO1 general register files are not identical as suggested by their original compatible. As there are no users of those yet, everybody agreed that we should fix the compatibles. * tag 'v6.11-rockchip-dtsfixes' of https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip: arm64: dts: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF dt-bindings: soc: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF arm64: dts: rockchip: override BIOS_DISABLE signal via GPIO hog on RK3399 Puma arm64: dts: rockchip: fix eMMC/SPI corruption when audio has been used on RK3399 Puma arm64: dts: rockchip: fix PMIC interrupt pin in pinctrl for ROCK Pi E arm64: dts: rockchip: Remove broken tsadc pinctrl binding for rk356x Link: https://lore.kernel.org/r/7602696.A5hrfCrGMc@diego Signed-off-by: Arnd Bergmann <[email protected]>
2 parents 95fe795 + 5956ee0 commit 2650fd8

File tree

5 files changed

+49
-12
lines changed

5 files changed

+49
-12
lines changed

Documentation/devicetree/bindings/soc/rockchip/grf.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,16 @@ properties:
3131
- rockchip,rk3588-pcie3-pipe-grf
3232
- rockchip,rk3588-usb-grf
3333
- rockchip,rk3588-usbdpphy-grf
34-
- rockchip,rk3588-vo-grf
34+
- rockchip,rk3588-vo0-grf
35+
- rockchip,rk3588-vo1-grf
3536
- rockchip,rk3588-vop-grf
3637
- rockchip,rv1108-usbgrf
3738
- const: syscon
39+
- items:
40+
- const: rockchip,rk3588-vo-grf
41+
- const: syscon
42+
deprecated: true
43+
description: Use rockchip,rk3588-vo{0,1}-grf instead.
3844
- items:
3945
- enum:
4046
- rockchip,px30-grf
@@ -262,6 +268,8 @@ allOf:
262268
contains:
263269
enum:
264270
- rockchip,rk3588-vo-grf
271+
- rockchip,rk3588-vo0-grf
272+
- rockchip,rk3588-vo1-grf
265273

266274
then:
267275
required:

arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@
387387

388388
pmic {
389389
pmic_int_l: pmic-int-l {
390-
rockchip,pins = <2 RK_PA6 RK_FUNC_GPIO &pcfg_pull_up>;
390+
rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_up>;
391391
};
392392
};
393393

arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi

Lines changed: 33 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,22 @@
154154
};
155155
};
156156

157+
&gpio3 {
158+
/*
159+
* The Qseven BIOS_DISABLE signal on the RK3399-Q7 keeps the on-module
160+
* eMMC and SPI flash powered-down initially (in fact it keeps the
161+
* reset signal asserted). BIOS_DISABLE_OVERRIDE pin allows to override
162+
* that signal so that eMMC and SPI can be used regardless of the state
163+
* of the signal.
164+
*/
165+
bios-disable-override-hog {
166+
gpios = <RK_PD5 GPIO_ACTIVE_LOW>;
167+
gpio-hog;
168+
line-name = "bios_disable_override";
169+
output-high;
170+
};
171+
};
172+
157173
&gmac {
158174
assigned-clocks = <&cru SCLK_RMII_SRC>;
159175
assigned-clock-parents = <&clkin_gmac>;
@@ -409,6 +425,7 @@
409425

410426
&i2s0 {
411427
pinctrl-0 = <&i2s0_2ch_bus>;
428+
pinctrl-1 = <&i2s0_2ch_bus_bclk_off>;
412429
rockchip,playback-channels = <2>;
413430
rockchip,capture-channels = <2>;
414431
status = "okay";
@@ -417,8 +434,8 @@
417434
/*
418435
* As Q7 does not specify neither a global nor a RX clock for I2S these
419436
* signals are not used. Furthermore I2S0_LRCK_RX is used as GPIO.
420-
* Therefore we have to redefine the i2s0_2ch_bus definition to prevent
421-
* conflicts.
437+
* Therefore we have to redefine the i2s0_2ch_bus and i2s0_2ch_bus_bclk_off
438+
* definitions to prevent conflicts.
422439
*/
423440
&i2s0_2ch_bus {
424441
rockchip,pins =
@@ -428,6 +445,14 @@
428445
<3 RK_PD7 1 &pcfg_pull_none>;
429446
};
430447

448+
&i2s0_2ch_bus_bclk_off {
449+
rockchip,pins =
450+
<3 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>,
451+
<3 RK_PD2 1 &pcfg_pull_none>,
452+
<3 RK_PD3 1 &pcfg_pull_none>,
453+
<3 RK_PD7 1 &pcfg_pull_none>;
454+
};
455+
431456
&io_domains {
432457
status = "okay";
433458
bt656-supply = <&vcc_1v8>;
@@ -449,9 +474,14 @@
449474

450475
&pinctrl {
451476
pinctrl-names = "default";
452-
pinctrl-0 = <&q7_thermal_pin>;
477+
pinctrl-0 = <&q7_thermal_pin &bios_disable_override_hog_pin>;
453478

454479
gpios {
480+
bios_disable_override_hog_pin: bios-disable-override-hog-pin {
481+
rockchip,pins =
482+
<3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_down>;
483+
};
484+
455485
q7_thermal_pin: q7-thermal-pin {
456486
rockchip,pins =
457487
<0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;

arch/arm64/boot/dts/rockchip/rk356x.dtsi

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1592,10 +1592,9 @@
15921592
<&cru SRST_TSADCPHY>;
15931593
rockchip,grf = <&grf>;
15941594
rockchip,hw-tshut-temp = <95000>;
1595-
pinctrl-names = "init", "default", "sleep";
1596-
pinctrl-0 = <&tsadc_pin>;
1597-
pinctrl-1 = <&tsadc_shutorg>;
1598-
pinctrl-2 = <&tsadc_pin>;
1595+
pinctrl-names = "default", "sleep";
1596+
pinctrl-0 = <&tsadc_shutorg>;
1597+
pinctrl-1 = <&tsadc_pin>;
15991598
#thermal-sensor-cells = <1>;
16001599
status = "disabled";
16011600
};

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -582,14 +582,14 @@
582582
};
583583

584584
vo0_grf: syscon@fd5a6000 {
585-
compatible = "rockchip,rk3588-vo-grf", "syscon";
585+
compatible = "rockchip,rk3588-vo0-grf", "syscon";
586586
reg = <0x0 0xfd5a6000 0x0 0x2000>;
587587
clocks = <&cru PCLK_VO0GRF>;
588588
};
589589

590590
vo1_grf: syscon@fd5a8000 {
591-
compatible = "rockchip,rk3588-vo-grf", "syscon";
592-
reg = <0x0 0xfd5a8000 0x0 0x100>;
591+
compatible = "rockchip,rk3588-vo1-grf", "syscon";
592+
reg = <0x0 0xfd5a8000 0x0 0x4000>;
593593
clocks = <&cru PCLK_VO1GRF>;
594594
};
595595

0 commit comments

Comments
 (0)