Skip to content

Commit 2668e3a

Browse files
committed
Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
Pull SCSI fixes from James Bottomley: "Two minor fixes: one in the core to improve the handling of warnings and unconditionally clear the command flags when ending a request and the other to add missing table values needed for bandwidth scaling in qualcomm ufs" * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: scsi: core: Fix handling of SCMD_FAIL_IF_RECOVERING scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5
2 parents 7586c85 + ca91259 commit 2668e3a

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

drivers/scsi/scsi_lib.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -635,10 +635,9 @@ static bool scsi_end_request(struct request *req, blk_status_t error,
635635
if (blk_queue_add_random(q))
636636
add_disk_randomness(req->q->disk);
637637

638-
if (!blk_rq_is_passthrough(req)) {
639-
WARN_ON_ONCE(!(cmd->flags & SCMD_INITIALIZED));
640-
cmd->flags &= ~SCMD_INITIALIZED;
641-
}
638+
WARN_ON_ONCE(!blk_rq_is_passthrough(req) &&
639+
!(cmd->flags & SCMD_INITIALIZED));
640+
cmd->flags = 0;
642641

643642
/*
644643
* Calling rcu_barrier() is not necessary here because the

drivers/ufs/host/ufs-qcom.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ enum {
4747
TSTBUS_MAX,
4848
};
4949

50-
#define QCOM_UFS_MAX_GEAR 4
50+
#define QCOM_UFS_MAX_GEAR 5
5151
#define QCOM_UFS_MAX_LANE 2
5252

5353
enum {
@@ -67,26 +67,32 @@ static const struct __ufs_qcom_bw_table {
6767
[MODE_PWM][UFS_PWM_G2][UFS_LANE_1] = { 1844, 1000 },
6868
[MODE_PWM][UFS_PWM_G3][UFS_LANE_1] = { 3688, 1000 },
6969
[MODE_PWM][UFS_PWM_G4][UFS_LANE_1] = { 7376, 1000 },
70+
[MODE_PWM][UFS_PWM_G5][UFS_LANE_1] = { 14752, 1000 },
7071
[MODE_PWM][UFS_PWM_G1][UFS_LANE_2] = { 1844, 1000 },
7172
[MODE_PWM][UFS_PWM_G2][UFS_LANE_2] = { 3688, 1000 },
7273
[MODE_PWM][UFS_PWM_G3][UFS_LANE_2] = { 7376, 1000 },
7374
[MODE_PWM][UFS_PWM_G4][UFS_LANE_2] = { 14752, 1000 },
75+
[MODE_PWM][UFS_PWM_G5][UFS_LANE_2] = { 29504, 1000 },
7476
[MODE_HS_RA][UFS_HS_G1][UFS_LANE_1] = { 127796, 1000 },
7577
[MODE_HS_RA][UFS_HS_G2][UFS_LANE_1] = { 255591, 1000 },
7678
[MODE_HS_RA][UFS_HS_G3][UFS_LANE_1] = { 1492582, 102400 },
7779
[MODE_HS_RA][UFS_HS_G4][UFS_LANE_1] = { 2915200, 204800 },
80+
[MODE_HS_RA][UFS_HS_G5][UFS_LANE_1] = { 5836800, 409600 },
7881
[MODE_HS_RA][UFS_HS_G1][UFS_LANE_2] = { 255591, 1000 },
7982
[MODE_HS_RA][UFS_HS_G2][UFS_LANE_2] = { 511181, 1000 },
8083
[MODE_HS_RA][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
8184
[MODE_HS_RA][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
85+
[MODE_HS_RA][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 },
8286
[MODE_HS_RB][UFS_HS_G1][UFS_LANE_1] = { 149422, 1000 },
8387
[MODE_HS_RB][UFS_HS_G2][UFS_LANE_1] = { 298189, 1000 },
8488
[MODE_HS_RB][UFS_HS_G3][UFS_LANE_1] = { 1492582, 102400 },
8589
[MODE_HS_RB][UFS_HS_G4][UFS_LANE_1] = { 2915200, 204800 },
90+
[MODE_HS_RB][UFS_HS_G5][UFS_LANE_1] = { 5836800, 409600 },
8691
[MODE_HS_RB][UFS_HS_G1][UFS_LANE_2] = { 298189, 1000 },
8792
[MODE_HS_RB][UFS_HS_G2][UFS_LANE_2] = { 596378, 1000 },
8893
[MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
8994
[MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
95+
[MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 },
9096
[MODE_MAX][0][0] = { 7643136, 307200 },
9197
};
9298

0 commit comments

Comments
 (0)