Skip to content

Commit 2699107

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI: video: Add acpi_backlight=video quirk for Apple iMac14,1 and iMac14,2
On the Apple iMac14,1 and iMac14,2 all-in-ones (monitors with builtin "PC") the connection between the GPU and the panel is seen by the GPU driver as regular DP instead of eDP, causing the GPU driver to never call acpi_video_register_backlight(). (GPU drivers only call acpi_video_register_backlight() when an internal panel is detected, to avoid non working acpi_video# devices getting registered on desktops which unfortunately is a real issue.) Fix the missing acpi_video# backlight device on these all-in-ones by adding a acpi_backlight=video DMI quirk, so that video.ko will immediately register the backlight device instead of waiting for an acpi_video_register_backlight() call. Fixes: 5aa9d94 ("ACPI: video: Don't enable fallback path for creating ACPI backlight by default") Cc: All applicable <[email protected]> Reviewed-by: Mario Limonciello <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent e506731 commit 2699107

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

drivers/acpi/video_detect.c

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,29 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
276276
},
277277
},
278278

279+
/*
280+
* Models which need acpi_video backlight control where the GPU drivers
281+
* do not call acpi_video_register_backlight() because no internal panel
282+
* is detected. Typically these are all-in-ones (monitors with builtin
283+
* PC) where the panel connection shows up as regular DP instead of eDP.
284+
*/
285+
{
286+
.callback = video_detect_force_video,
287+
/* Apple iMac14,1 */
288+
.matches = {
289+
DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
290+
DMI_MATCH(DMI_PRODUCT_NAME, "iMac14,1"),
291+
},
292+
},
293+
{
294+
.callback = video_detect_force_video,
295+
/* Apple iMac14,2 */
296+
.matches = {
297+
DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
298+
DMI_MATCH(DMI_PRODUCT_NAME, "iMac14,2"),
299+
},
300+
},
301+
279302
/*
280303
* These models have a working acpi_video backlight control, and using
281304
* native backlight causes a regression where backlight does not work

0 commit comments

Comments
 (0)