Skip to content

Commit 26c04a8

Browse files
soyersoyertiwai
authored andcommitted
ALSA: hda/tas2781: add debug statements to kcontrols
Sometimes it is useful to examine the timing of kcontrol events. Add debug statements to each kcontrol. Signed-off-by: Gergo Koteles <[email protected]> Message-ID: <18ff4b0caab90a2dacf907e62346fd5079a9eb1a.1711469583.git.soyer@irl.hu> Signed-off-by: Takashi Iwai <[email protected]>
1 parent 15bc306 commit 26c04a8

File tree

1 file changed

+31
-4
lines changed

1 file changed

+31
-4
lines changed

sound/pci/hda/tas2781_hda_i2c.c

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,9 @@ static int tasdevice_get_profile_id(struct snd_kcontrol *kcontrol,
189189

190190
ucontrol->value.integer.value[0] = tas_priv->rcabin.profile_cfg_id;
191191

192+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n",
193+
__func__, kcontrol->id.name, tas_priv->rcabin.profile_cfg_id);
194+
192195
mutex_unlock(&tas_priv->codec_lock);
193196

194197
return 0;
@@ -206,6 +209,10 @@ static int tasdevice_set_profile_id(struct snd_kcontrol *kcontrol,
206209

207210
mutex_lock(&tas_priv->codec_lock);
208211

212+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n",
213+
__func__, kcontrol->id.name,
214+
tas_priv->rcabin.profile_cfg_id, val);
215+
209216
if (tas_priv->rcabin.profile_cfg_id != val) {
210217
tas_priv->rcabin.profile_cfg_id = val;
211218
ret = 1;
@@ -253,6 +260,9 @@ static int tasdevice_program_get(struct snd_kcontrol *kcontrol,
253260

254261
ucontrol->value.integer.value[0] = tas_priv->cur_prog;
255262

263+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n",
264+
__func__, kcontrol->id.name, tas_priv->cur_prog);
265+
256266
mutex_unlock(&tas_priv->codec_lock);
257267

258268
return 0;
@@ -271,6 +281,9 @@ static int tasdevice_program_put(struct snd_kcontrol *kcontrol,
271281

272282
mutex_lock(&tas_priv->codec_lock);
273283

284+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n",
285+
__func__, kcontrol->id.name, tas_priv->cur_prog, val);
286+
274287
if (tas_priv->cur_prog != val) {
275288
tas_priv->cur_prog = val;
276289
ret = 1;
@@ -290,6 +303,9 @@ static int tasdevice_config_get(struct snd_kcontrol *kcontrol,
290303

291304
ucontrol->value.integer.value[0] = tas_priv->cur_conf;
292305

306+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n",
307+
__func__, kcontrol->id.name, tas_priv->cur_conf);
308+
293309
mutex_unlock(&tas_priv->codec_lock);
294310

295311
return 0;
@@ -308,6 +324,9 @@ static int tasdevice_config_put(struct snd_kcontrol *kcontrol,
308324

309325
mutex_lock(&tas_priv->codec_lock);
310326

327+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n",
328+
__func__, kcontrol->id.name, tas_priv->cur_conf, val);
329+
311330
if (tas_priv->cur_conf != val) {
312331
tas_priv->cur_conf = val;
313332
ret = 1;
@@ -330,6 +349,9 @@ static int tas2781_amp_getvol(struct snd_kcontrol *kcontrol,
330349

331350
ret = tasdevice_amp_getvol(tas_priv, ucontrol, mc);
332351

352+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %ld\n",
353+
__func__, kcontrol->id.name, ucontrol->value.integer.value[0]);
354+
333355
mutex_unlock(&tas_priv->codec_lock);
334356

335357
return ret;
@@ -345,6 +367,9 @@ static int tas2781_amp_putvol(struct snd_kcontrol *kcontrol,
345367

346368
mutex_lock(&tas_priv->codec_lock);
347369

370+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: -> %ld\n",
371+
__func__, kcontrol->id.name, ucontrol->value.integer.value[0]);
372+
348373
/* The check of the given value is in tasdevice_amp_putvol. */
349374
ret = tasdevice_amp_putvol(tas_priv, ucontrol, mc);
350375

@@ -361,8 +386,8 @@ static int tas2781_force_fwload_get(struct snd_kcontrol *kcontrol,
361386
mutex_lock(&tas_priv->codec_lock);
362387

363388
ucontrol->value.integer.value[0] = (int)tas_priv->force_fwload_status;
364-
dev_dbg(tas_priv->dev, "%s : Force FWload %s\n", __func__,
365-
tas_priv->force_fwload_status ? "ON" : "OFF");
389+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n",
390+
__func__, kcontrol->id.name, tas_priv->force_fwload_status);
366391

367392
mutex_unlock(&tas_priv->codec_lock);
368393

@@ -377,14 +402,16 @@ static int tas2781_force_fwload_put(struct snd_kcontrol *kcontrol,
377402

378403
mutex_lock(&tas_priv->codec_lock);
379404

405+
dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n",
406+
__func__, kcontrol->id.name,
407+
tas_priv->force_fwload_status, val);
408+
380409
if (tas_priv->force_fwload_status == val)
381410
change = false;
382411
else {
383412
change = true;
384413
tas_priv->force_fwload_status = val;
385414
}
386-
dev_dbg(tas_priv->dev, "%s : Force FWload %s\n", __func__,
387-
tas_priv->force_fwload_status ? "ON" : "OFF");
388415

389416
mutex_unlock(&tas_priv->codec_lock);
390417

0 commit comments

Comments
 (0)