Skip to content

Commit 26d2891

Browse files
mbrost05rodrigovivi
authored andcommitted
drm/xe: Drop trace_xe_hw_fence_free
fence->ctx may be stale memory when trace_xe_hw_fence_free is called resuling UAF bug when deriving the device name. This tracepoint is not all that useful, so just drop it. Fixes: 501c425 ("drm/xe/trace: Print device_id in xe_trace events") Cc: Ville Syrjälä <[email protected]> Cc: Lucas De Marchi <[email protected]> Cc: Gustavo Sousa <[email protected]> Cc: Radhakrishna Sripada <[email protected]> Cc: Matt Roper <[email protected]> Signed-off-by: Matthew Brost <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit caaf1f4) Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent 63347fe commit 26d2891

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

drivers/gpu/drm/xe/xe_hw_fence.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ static void xe_hw_fence_release(struct dma_fence *dma_fence)
187187
{
188188
struct xe_hw_fence *fence = to_xe_hw_fence(dma_fence);
189189

190-
trace_xe_hw_fence_free(fence);
191190
XE_WARN_ON(!list_empty(&fence->irq_link));
192191
call_rcu(&dma_fence->rcu, fence_free);
193192
}

drivers/gpu/drm/xe/xe_trace.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -341,11 +341,6 @@ DEFINE_EVENT(xe_hw_fence, xe_hw_fence_try_signal,
341341
TP_ARGS(fence)
342342
);
343343

344-
DEFINE_EVENT(xe_hw_fence, xe_hw_fence_free,
345-
TP_PROTO(struct xe_hw_fence *fence),
346-
TP_ARGS(fence)
347-
);
348-
349344
TRACE_EVENT(xe_reg_rw,
350345
TP_PROTO(struct xe_gt *gt, bool write, u32 reg, u64 val, int len),
351346

0 commit comments

Comments
 (0)