blk-wbt: remove wbt_update_limits

Guoqing Jiang · axboe · commit 26e0ca12e076 · 2020-05-29T16:30:39.000-06:00
No one call this function after commit 2af2783 ("rq-qos: get rid of redundant wbt_update_limits()"), so remove it. Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
@@ -418,14 +418,6 @@ static void __wbt_update_limits(struct rq_wb *rwb)
 	rwb_wake_all(rwb);
 }
 
-void wbt_update_limits(struct request_queue *q)
-{
-	struct rq_qos *rqos = wbt_rq_qos(q);
-	if (!rqos)
-		return;
-	__wbt_update_limits(RQWB(rqos));
-}
-
 u64 wbt_get_min_lat(struct request_queue *q)
 {
 	struct rq_qos *rqos = wbt_rq_qos(q);
diff --git a/block/blk-wbt.h b/block/blk-wbt.h
@@ -88,7 +88,6 @@ static inline unsigned int wbt_inflight(struct rq_wb *rwb)
 #ifdef CONFIG_BLK_WBT
 
 int wbt_init(struct request_queue *);
-void wbt_update_limits(struct request_queue *);
 void wbt_disable_default(struct request_queue *);
 void wbt_enable_default(struct request_queue *);
 
@@ -108,9 +107,6 @@ static inline int wbt_init(struct request_queue *q)
 {
 	return -EINVAL;
 }
-static inline void wbt_update_limits(struct request_queue *q)
-{
-}
 static inline void wbt_disable_default(struct request_queue *q)
 {
 }

Original file line number	Diff line number	Diff line change
`@@ -418,14 +418,6 @@ static void __wbt_update_limits(struct rq_wb *rwb)`
`418`	`418`	`rwb_wake_all(rwb);`
`419`	`419`	`}`
`420`	`420`
`421`		`-void wbt_update_limits(struct request_queue *q)`
`422`		`-{`
`423`		`- struct rq_qos *rqos = wbt_rq_qos(q);`
`424`		`- if (!rqos)`
`425`		`- return;`
`426`		`- __wbt_update_limits(RQWB(rqos));`
`427`		`-}`
`428`		`-`
`429`	`421`	`u64 wbt_get_min_lat(struct request_queue *q)`
`430`	`422`	`{`
`431`	`423`	`struct rq_qos *rqos = wbt_rq_qos(q);`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,6 @@ static inline unsigned int wbt_inflight(struct rq_wb *rwb)`
`88`	`88`	`#ifdef CONFIG_BLK_WBT`
`89`	`89`
`90`	`90`	`int wbt_init(struct request_queue *);`
`91`		`-void wbt_update_limits(struct request_queue *);`
`92`	`91`	`void wbt_disable_default(struct request_queue *);`
`93`	`92`	`void wbt_enable_default(struct request_queue *);`
`94`	`93`
`@@ -108,9 +107,6 @@ static inline int wbt_init(struct request_queue *q)`
`108`	`107`	`{`
`109`	`108`	`return -EINVAL;`
`110`	`109`	`}`
`111`		`-static inline void wbt_update_limits(struct request_queue *q)`
`112`		`-{`
`113`		`-}`
`114`	`110`	`static inline void wbt_disable_default(struct request_queue *q)`
`115`	`111`	`{`
`116`	`112`	`}`