Skip to content

Commit 26f2d6d

Browse files
CoelacanthusHexpalmer-dabbelt
authored andcommitted
riscv: defconfig: drop RT_GROUP_SCHED=y
Commit ba6cfef ("riscv: enable Docker requirements in defconfig") introduced it because of Docker, but Docker has removed this requirement since [1] (2023-04-19). For cgroup v1, if turned on, and there's any cgroup in the "cpu" hierarchy it needs an RT budget assigned, otherwise the processes in it will not be able to get RT at all. The problem with RT group scheduling is that it requires the budget assigned but there's no way we could assign a default budget, since the values to assign are both upper and lower time limits, are absolute, and need to be sum up to < 1 for each individal cgroup. That means we cannot really come up with values that would work by default in the general case.[2] For cgroup v2, it's almost unusable as well. If it turned on, the cpu controller can only be enabled when all RT processes are in the root cgroup. But it will lose the benefits of cgroup v2 if all RT process were placed in the same cgroup. Red Hat, Gentoo, Arch Linux and Debian all disable it. systemd also doesn't support it.[3] [1]: moby/moby@005150e [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1229700 [3]: systemd/systemd#13781 (comment) Acked-by: Heinrich Schuchardt <[email protected]> Signed-off-by: Celeste Liu <[email protected]> Acked-by: Charlie Jenkins <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Palmer Dabbelt <[email protected]>
1 parent 9d0593d commit 26f2d6d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

arch/riscv/configs/defconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ CONFIG_MEMCG=y
1010
CONFIG_BLK_CGROUP=y
1111
CONFIG_CGROUP_SCHED=y
1212
CONFIG_CFS_BANDWIDTH=y
13-
CONFIG_RT_GROUP_SCHED=y
1413
CONFIG_CGROUP_PIDS=y
1514
CONFIG_CGROUP_FREEZER=y
1615
CONFIG_CGROUP_HUGETLB=y

0 commit comments

Comments
 (0)