Skip to content

Commit 275a63c

Browse files
daniellertskuba-moo
authored andcommitted
net: ethtool: Monotonically increase the message sequence number
Currently, during the module firmware flashing process, unicast notifications are sent from the kernel using the same sequence number, making it impossible for user space to track missed notifications. Monotonically increase the message sequence number, so the order of notifications could be tracked effectively. Signed-off-by: Danielle Ratson <[email protected]> Reviewed-by: Ido Schimmel <[email protected]> Reviewed-by: Jakub Kicinski <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 646d2ac commit 275a63c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/ethtool/module.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ ethnl_module_fw_flash_ntf(struct net_device *dev,
488488
if (!skb)
489489
return;
490490

491-
hdr = ethnl_unicast_put(skb, ntf_params->portid, ntf_params->seq,
491+
hdr = ethnl_unicast_put(skb, ntf_params->portid, ++ntf_params->seq,
492492
ETHTOOL_MSG_MODULE_FW_FLASH_NTF);
493493
if (!hdr)
494494
goto err_skb;

0 commit comments

Comments
 (0)