Skip to content

Commit 275dac1

Browse files
johnharr-inteljlahtine-intel
authored andcommitted
drm/i915/guc: Don't capture Gen8 regs on Xe devices
A pair of pre-Xe registers were being included in the Xe capture list. GuC was rejecting those as being invalid and logging errors about them. So, stop doing it. Signed-off-by: John Harrison <[email protected]> Reviewed-by: Alan Previn <[email protected]> Fixes: dce2bd5 ("drm/i915/guc: Add Gen9 registers for GuC error state capture.") Cc: Alan Previn <[email protected]> Cc: Umesh Nerlige Ramappa <[email protected]> Cc: Lucas De Marchi <[email protected]> Cc: John Harrison <[email protected]> Cc: Jani Nikula <[email protected]> Cc: Matt Roper <[email protected]> Cc: Balasubramani Vivekanandan <[email protected]> Cc: Daniele Ceraolo Spurio <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit b049132) Signed-off-by: Joonas Lahtinen <[email protected]>
1 parent ac9a786 commit 275dac1

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,14 @@
3131
{ FORCEWAKE_MT, 0, 0, "FORCEWAKE" }
3232

3333
#define COMMON_GEN9BASE_GLOBAL \
34-
{ GEN8_FAULT_TLB_DATA0, 0, 0, "GEN8_FAULT_TLB_DATA0" }, \
35-
{ GEN8_FAULT_TLB_DATA1, 0, 0, "GEN8_FAULT_TLB_DATA1" }, \
3634
{ ERROR_GEN6, 0, 0, "ERROR_GEN6" }, \
3735
{ DONE_REG, 0, 0, "DONE_REG" }, \
3836
{ HSW_GTT_CACHE_EN, 0, 0, "HSW_GTT_CACHE_EN" }
3937

38+
#define GEN9_GLOBAL \
39+
{ GEN8_FAULT_TLB_DATA0, 0, 0, "GEN8_FAULT_TLB_DATA0" }, \
40+
{ GEN8_FAULT_TLB_DATA1, 0, 0, "GEN8_FAULT_TLB_DATA1" }
41+
4042
#define COMMON_GEN12BASE_GLOBAL \
4143
{ GEN12_FAULT_TLB_DATA0, 0, 0, "GEN12_FAULT_TLB_DATA0" }, \
4244
{ GEN12_FAULT_TLB_DATA1, 0, 0, "GEN12_FAULT_TLB_DATA1" }, \
@@ -142,6 +144,7 @@ static const struct __guc_mmio_reg_descr xe_lpd_gsc_inst_regs[] = {
142144
static const struct __guc_mmio_reg_descr default_global_regs[] = {
143145
COMMON_BASE_GLOBAL,
144146
COMMON_GEN9BASE_GLOBAL,
147+
GEN9_GLOBAL,
145148
};
146149

147150
static const struct __guc_mmio_reg_descr default_rc_class_regs[] = {

0 commit comments

Comments
 (0)