Skip to content

Commit 279676c

Browse files
weiny2djbw
authored andcommitted
cxl/trace: Add serial number to trace points
Device serial numbers are useful information for the user. Add device serial numbers to all the trace points. Cc: Steven Rostedt <[email protected]> Cc: Dave Jiang <[email protected]> Signed-off-by: Ira Weiny <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dan Williams <[email protected]>
1 parent cd05701 commit 279676c

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

drivers/cxl/core/trace.h

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,15 @@ TRACE_EVENT(cxl_aer_uncorrectable_error,
5252
TP_STRUCT__entry(
5353
__string(memdev, dev_name(&cxlmd->dev))
5454
__string(host, dev_name(cxlmd->dev.parent))
55+
__field(u64, serial)
5556
__field(u32, status)
5657
__field(u32, first_error)
5758
__array(u32, header_log, CXL_HEADERLOG_SIZE_U32)
5859
),
5960
TP_fast_assign(
6061
__assign_str(memdev, dev_name(&cxlmd->dev));
6162
__assign_str(host, dev_name(cxlmd->dev.parent));
63+
__entry->serial = cxlmd->cxlds->serial;
6264
__entry->status = status;
6365
__entry->first_error = fe;
6466
/*
@@ -67,8 +69,8 @@ TRACE_EVENT(cxl_aer_uncorrectable_error,
6769
*/
6870
memcpy(__entry->header_log, hl, CXL_HEADERLOG_SIZE);
6971
),
70-
TP_printk("memdev=%s host=%s: status: '%s' first_error: '%s'",
71-
__get_str(memdev), __get_str(host),
72+
TP_printk("memdev=%s host=%s serial=%lld: status: '%s' first_error: '%s'",
73+
__get_str(memdev), __get_str(host), __entry->serial,
7274
show_uc_errs(__entry->status),
7375
show_uc_errs(__entry->first_error)
7476
)
@@ -98,15 +100,17 @@ TRACE_EVENT(cxl_aer_correctable_error,
98100
TP_STRUCT__entry(
99101
__string(memdev, dev_name(&cxlmd->dev))
100102
__string(host, dev_name(cxlmd->dev.parent))
103+
__field(u64, serial)
101104
__field(u32, status)
102105
),
103106
TP_fast_assign(
104107
__assign_str(memdev, dev_name(&cxlmd->dev));
105108
__assign_str(host, dev_name(cxlmd->dev.parent));
109+
__entry->serial = cxlmd->cxlds->serial;
106110
__entry->status = status;
107111
),
108-
TP_printk("memdev=%s host=%s: status: '%s'",
109-
__get_str(memdev), __get_str(host),
112+
TP_printk("memdev=%s host=%s serial=%lld: status: '%s'",
113+
__get_str(memdev), __get_str(host), __entry->serial,
110114
show_ce_errs(__entry->status)
111115
)
112116
);
@@ -129,6 +133,7 @@ TRACE_EVENT(cxl_overflow,
129133
__string(memdev, dev_name(&cxlmd->dev))
130134
__string(host, dev_name(cxlmd->dev.parent))
131135
__field(int, log)
136+
__field(u64, serial)
132137
__field(u64, first_ts)
133138
__field(u64, last_ts)
134139
__field(u16, count)
@@ -137,14 +142,15 @@ TRACE_EVENT(cxl_overflow,
137142
TP_fast_assign(
138143
__assign_str(memdev, dev_name(&cxlmd->dev));
139144
__assign_str(host, dev_name(cxlmd->dev.parent));
145+
__entry->serial = cxlmd->cxlds->serial;
140146
__entry->log = log;
141147
__entry->count = le16_to_cpu(payload->overflow_err_count);
142148
__entry->first_ts = le64_to_cpu(payload->first_overflow_timestamp);
143149
__entry->last_ts = le64_to_cpu(payload->last_overflow_timestamp);
144150
),
145151

146-
TP_printk("memdev=%s host=%s: log=%s : %u records from %llu to %llu",
147-
__get_str(memdev), __get_str(host),
152+
TP_printk("memdev=%s host=%s serial=%lld: log=%s : %u records from %llu to %llu",
153+
__get_str(memdev), __get_str(host), __entry->serial,
148154
cxl_event_log_type_str(__entry->log), __entry->count,
149155
__entry->first_ts, __entry->last_ts)
150156

@@ -182,6 +188,7 @@ TRACE_EVENT(cxl_overflow,
182188
__string(host, dev_name(cxlmd->dev.parent)) \
183189
__field(int, log) \
184190
__field_struct(uuid_t, hdr_uuid) \
191+
__field(u64, serial) \
185192
__field(u32, hdr_flags) \
186193
__field(u16, hdr_handle) \
187194
__field(u16, hdr_related_handle) \
@@ -193,6 +200,7 @@ TRACE_EVENT(cxl_overflow,
193200
__assign_str(memdev, dev_name(&(cxlmd)->dev)); \
194201
__assign_str(host, dev_name((cxlmd)->dev.parent)); \
195202
__entry->log = (l); \
203+
__entry->serial = (cxlmd)->cxlds->serial; \
196204
memcpy(&__entry->hdr_uuid, &(hdr).id, sizeof(uuid_t)); \
197205
__entry->hdr_length = (hdr).length; \
198206
__entry->hdr_flags = get_unaligned_le24((hdr).flags); \
@@ -202,10 +210,10 @@ TRACE_EVENT(cxl_overflow,
202210
__entry->hdr_maint_op_class = (hdr).maint_op_class
203211

204212
#define CXL_EVT_TP_printk(fmt, ...) \
205-
TP_printk("memdev=%s host=%s log=%s : time=%llu uuid=%pUb len=%d " \
206-
"flags='%s' handle=%x related_handle=%x maint_op_class=%u" \
207-
" : " fmt, \
208-
__get_str(memdev), __get_str(host), \
213+
TP_printk("memdev=%s host=%s serial=%lld log=%s : time=%llu uuid=%pUb " \
214+
"len=%d flags='%s' handle=%x related_handle=%x " \
215+
"maint_op_class=%u : " fmt, \
216+
__get_str(memdev), __get_str(host), __entry->serial, \
209217
cxl_event_log_type_str(__entry->log), \
210218
__entry->hdr_timestamp, &__entry->hdr_uuid, __entry->hdr_length,\
211219
show_hdr_flags(__entry->hdr_flags), __entry->hdr_handle, \

0 commit comments

Comments
 (0)