Skip to content

Commit 279c12d

Browse files
palibrgl
authored andcommitted
gpio: mpc8xxx: Fix support for IRQ_TYPE_LEVEL_LOW flow_type in mpc85xx
Commit e39d5ef ("powerpc/5xxx: extend mpc8xxx_gpio driver to support mpc512x gpios") implemented support for IRQ_TYPE_LEVEL_LOW flow type in mpc512x via falling edge type. Do same for mpc85xx which support was added in commit 345e5c8 ("powerpc: Add interrupt support to mpc8xxx_gpio"). Fixes probing of lm90 hwmon driver on mpc85xx based board which use level interrupt. Without it kernel prints error and refuse lm90 to work: [ 15.258370] genirq: Setting trigger mode 8 for irq 49 failed (mpc8xxx_irq_set_type+0x0/0xf8) [ 15.267168] lm90 0-004c: cannot request IRQ 49 [ 15.272708] lm90: probe of 0-004c failed with error -22 Fixes: 345e5c8 ("powerpc: Add interrupt support to mpc8xxx_gpio") Signed-off-by: Pali Rohár <[email protected]> Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent 7e18e42 commit 279c12d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpio/gpio-mpc8xxx.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ static int mpc8xxx_irq_set_type(struct irq_data *d, unsigned int flow_type)
169169

170170
switch (flow_type) {
171171
case IRQ_TYPE_EDGE_FALLING:
172+
case IRQ_TYPE_LEVEL_LOW:
172173
raw_spin_lock_irqsave(&mpc8xxx_gc->lock, flags);
173174
gc->write_reg(mpc8xxx_gc->regs + GPIO_ICR,
174175
gc->read_reg(mpc8xxx_gc->regs + GPIO_ICR)

0 commit comments

Comments
 (0)