Skip to content

Commit 27a6f70

Browse files
khfengbentiss
authored andcommitted
HID: multitouch: Remove MT_CLS_WIN_8_DUAL
After commit c23e204 ("HID: multitouch: do not filter mice nodes"), MT_CLS_WIN_8 also supports mouse nodes, hence make MT_CLS_WIN_8_DUAL redundant. Remove MT_CLS_WIN_8_DUAL accordingly. Signed-off-by: Kai-Heng Feng <[email protected]> Signed-off-by: Benjamin Tissoires <[email protected]>
1 parent 40d5bb8 commit 27a6f70

File tree

2 files changed

+2
-50
lines changed

2 files changed

+2
-50
lines changed

drivers/hid/hid-ids.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,9 @@
7676

7777
#define USB_VENDOR_ID_ALPS_JP 0x044E
7878
#define HID_DEVICE_ID_ALPS_U1_DUAL 0x120B
79-
#define HID_DEVICE_ID_ALPS_U1_DUAL_PTP 0x121F
80-
#define HID_DEVICE_ID_ALPS_U1_DUAL_3BTN_PTP 0x1220
8179
#define HID_DEVICE_ID_ALPS_U1 0x1215
8280
#define HID_DEVICE_ID_ALPS_U1_UNICORN_LEGACY 0x121E
8381
#define HID_DEVICE_ID_ALPS_T4_BTNLESS 0x120C
84-
#define HID_DEVICE_ID_ALPS_1222 0x1222
8582

8683
#define USB_VENDOR_ID_AMI 0x046b
8784
#define USB_DEVICE_ID_AMI_VIRT_KEYBOARD_AND_MOUSE 0xff10
@@ -281,9 +278,6 @@
281278

282279
#define USB_VENDOR_ID_CIDC 0x1677
283280

284-
#define I2C_VENDOR_ID_CIRQUE 0x0488
285-
#define I2C_PRODUCT_ID_CIRQUE_121F 0x121F
286-
287281
#define USB_VENDOR_ID_CJTOUCH 0x24b8
288282
#define USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0020 0x0020
289283
#define USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0040 0x0040
@@ -730,8 +724,6 @@
730724
#define USB_DEVICE_ID_LENOVO_SCROLLPOINT_OPTICAL 0x6049
731725
#define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067
732726
#define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
733-
#define USB_DEVICE_ID_LENOVO_X1_TAB 0x60a3
734-
#define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
735727
#define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d
736728

737729
#define USB_VENDOR_ID_LG 0x1fd2

drivers/hid/hid-multitouch.c

Lines changed: 2 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ static void mt_post_parse(struct mt_device *td, struct mt_application *app);
189189
/* reserved 0x0011 */
190190
#define MT_CLS_WIN_8 0x0012
191191
#define MT_CLS_EXPORT_ALL_INPUTS 0x0013
192-
#define MT_CLS_WIN_8_DUAL 0x0014
192+
/* reserved 0x0014 */
193193
#define MT_CLS_WIN_8_FORCE_MULTI_INPUT 0x0015
194194

195195
/* vendor specific classes */
@@ -274,13 +274,6 @@ static const struct mt_class mt_classes[] = {
274274
.quirks = MT_QUIRK_ALWAYS_VALID |
275275
MT_QUIRK_CONTACT_CNT_ACCURATE,
276276
.export_all_inputs = true },
277-
{ .name = MT_CLS_WIN_8_DUAL,
278-
.quirks = MT_QUIRK_ALWAYS_VALID |
279-
MT_QUIRK_IGNORE_DUPLICATES |
280-
MT_QUIRK_HOVERING |
281-
MT_QUIRK_CONTACT_CNT_ACCURATE |
282-
MT_QUIRK_WIN8_PTP_BUTTONS,
283-
.export_all_inputs = true },
284277
{ .name = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
285278
.quirks = MT_QUIRK_ALWAYS_VALID |
286279
MT_QUIRK_IGNORE_DUPLICATES |
@@ -765,8 +758,7 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
765758
MT_STORE_FIELD(inrange_state);
766759
return 1;
767760
case HID_DG_CONFIDENCE:
768-
if ((cls->name == MT_CLS_WIN_8 ||
769-
cls->name == MT_CLS_WIN_8_DUAL) &&
761+
if (cls->name == MT_CLS_WIN_8 &&
770762
(field->application == HID_DG_TOUCHPAD ||
771763
field->application == HID_DG_TOUCHSCREEN))
772764
app->quirks |= MT_QUIRK_CONFIDENCE;
@@ -1802,32 +1794,6 @@ static const struct hid_device_id mt_devices[] = {
18021794
MT_USB_DEVICE(USB_VENDOR_ID_3M,
18031795
USB_DEVICE_ID_3M3266) },
18041796

1805-
/* Alps devices */
1806-
{ .driver_data = MT_CLS_WIN_8_DUAL,
1807-
HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
1808-
USB_VENDOR_ID_ALPS_JP,
1809-
HID_DEVICE_ID_ALPS_U1_DUAL_PTP) },
1810-
{ .driver_data = MT_CLS_WIN_8_DUAL,
1811-
HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
1812-
USB_VENDOR_ID_ALPS_JP,
1813-
HID_DEVICE_ID_ALPS_U1_DUAL_3BTN_PTP) },
1814-
{ .driver_data = MT_CLS_WIN_8_DUAL,
1815-
HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
1816-
USB_VENDOR_ID_ALPS_JP,
1817-
HID_DEVICE_ID_ALPS_1222) },
1818-
1819-
/* Lenovo X1 TAB Gen 2 */
1820-
{ .driver_data = MT_CLS_WIN_8_DUAL,
1821-
HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
1822-
USB_VENDOR_ID_LENOVO,
1823-
USB_DEVICE_ID_LENOVO_X1_TAB) },
1824-
1825-
/* Lenovo X1 TAB Gen 3 */
1826-
{ .driver_data = MT_CLS_WIN_8_DUAL,
1827-
HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
1828-
USB_VENDOR_ID_LENOVO,
1829-
USB_DEVICE_ID_LENOVO_X1_TAB3) },
1830-
18311797
/* Anton devices */
18321798
{ .driver_data = MT_CLS_EXPORT_ALL_INPUTS,
18331799
MT_USB_DEVICE(USB_VENDOR_ID_ANTON,
@@ -1862,12 +1828,6 @@ static const struct hid_device_id mt_devices[] = {
18621828
MT_USB_DEVICE(USB_VENDOR_ID_CHUNGHWAT,
18631829
USB_DEVICE_ID_CHUNGHWAT_MULTITOUCH) },
18641830

1865-
/* Cirque devices */
1866-
{ .driver_data = MT_CLS_WIN_8_DUAL,
1867-
HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
1868-
I2C_VENDOR_ID_CIRQUE,
1869-
I2C_PRODUCT_ID_CIRQUE_121F) },
1870-
18711831
/* CJTouch panels */
18721832
{ .driver_data = MT_CLS_NSMU,
18731833
MT_USB_DEVICE(USB_VENDOR_ID_CJTOUCH,

0 commit comments

Comments
 (0)