Skip to content

Commit 27c3e94

Browse files
author
Thomas Zimmermann
committed
drm/fb-helper: Remove damage worker
The fbdev damage worker is unused, so remove it. Signed-off-by: Thomas Zimmermann <[email protected]> Reviewed-by: Daniel Vetter <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 7f5cc4a commit 27c3e94

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

drivers/gpu/drm/drm_fb_helper.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -403,13 +403,6 @@ static void drm_fb_helper_fb_dirty(struct drm_fb_helper *helper)
403403
spin_unlock_irqrestore(&helper->damage_lock, flags);
404404
}
405405

406-
static void drm_fb_helper_damage_work(struct work_struct *work)
407-
{
408-
struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work);
409-
410-
drm_fb_helper_fb_dirty(helper);
411-
}
412-
413406
/**
414407
* drm_fb_helper_prepare - setup a drm_fb_helper structure
415408
* @dev: DRM device
@@ -425,7 +418,6 @@ void drm_fb_helper_prepare(struct drm_device *dev, struct drm_fb_helper *helper,
425418
INIT_LIST_HEAD(&helper->kernel_fb_list);
426419
spin_lock_init(&helper->damage_lock);
427420
INIT_WORK(&helper->resume_work, drm_fb_helper_resume_worker);
428-
INIT_WORK(&helper->damage_work, drm_fb_helper_damage_work);
429421
helper->damage_clip.x1 = helper->damage_clip.y1 = ~0;
430422
mutex_init(&helper->lock);
431423
helper->funcs = funcs;
@@ -557,7 +549,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
557549
return;
558550

559551
cancel_work_sync(&fb_helper->resume_work);
560-
cancel_work_sync(&fb_helper->damage_work);
561552

562553
info = fb_helper->info;
563554
if (info) {

include/drm/drm_fb_helper.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ struct drm_fb_helper_funcs {
116116
* @damage_clip: clip rectangle used with deferred_io to accumulate damage to
117117
* the screen buffer
118118
* @damage_lock: spinlock protecting @damage_clip
119-
* @damage_work: worker used to flush the framebuffer
120119
* @resume_work: worker used during resume if the console lock is already taken
121120
*
122121
* This is the main structure used by the fbdev helpers. Drivers supporting
@@ -146,7 +145,6 @@ struct drm_fb_helper {
146145
u32 pseudo_palette[17];
147146
struct drm_clip_rect damage_clip;
148147
spinlock_t damage_lock;
149-
struct work_struct damage_work;
150148
struct work_struct resume_work;
151149

152150
/**

0 commit comments

Comments
 (0)