Skip to content

Commit 28127db

Browse files
vsyrjalaalexdeucher
authored andcommitted
drm/radeon: Fix encoder->possible_clones
Include the encoder itself in its possible_clones bitmask. In the past nothing validated that drivers were populating possible_clones correctly, but that changed in commit 74d2aac ("drm: Validate encoder->possible_clones"). Looks like radeon never got the memo and is still not following the rules 100% correctly. This results in some warnings during driver initialization: Bogus possible_clones: [ENCODER:46:TV-46] possible_clones=0x4 (full encoder mask=0x7) WARNING: CPU: 0 PID: 170 at drivers/gpu/drm/drm_mode_config.c:615 drm_mode_config_validate+0x113/0x39c ... Cc: Alex Deucher <[email protected]> Cc: [email protected] Fixes: 74d2aac ("drm: Validate encoder->possible_clones") Reported-by: Erhard Furtner <[email protected]> Closes: https://lore.kernel.org/dri-devel/20241009000321.418e4294@yea/ Tested-by: Erhard Furtner <[email protected]> Signed-off-by: Ville Syrjälä <[email protected]> Signed-off-by: Alex Deucher <[email protected]> (cherry picked from commit 3b6e7d4) Cc: [email protected]
1 parent 7a1613e commit 28127db

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/radeon/radeon_encoders.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ static uint32_t radeon_encoder_clones(struct drm_encoder *encoder)
4343
struct radeon_device *rdev = dev->dev_private;
4444
struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
4545
struct drm_encoder *clone_encoder;
46-
uint32_t index_mask = 0;
46+
uint32_t index_mask = drm_encoder_mask(encoder);
4747
int count;
4848

4949
/* DIG routing gets problematic */

0 commit comments

Comments
 (0)