Skip to content

Commit 283730b

Browse files
konradybciogregkh
authored andcommitted
arm64: dts: qcom: sdm630: Drop RPM bus clocks
Some nodes are abusingly referencing some of the internal bus clocks, that were recently removed in Linux (because the original implementation did not make much sense), managing them as if they were the only devices on an NoC bus. These clocks are now handled from within the icc framework and are no longer registered from within the CCF. Remove them. Reviewed-by: Marijn Suijten <[email protected]> Signed-off-by: Konrad Dybcio <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 437afce commit 283730b

File tree

1 file changed

+12
-41
lines changed

1 file changed

+12
-41
lines changed

arch/arm64/boot/dts/qcom/sdm630.dtsi

Lines changed: 12 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -606,9 +606,6 @@
606606
compatible = "qcom,sdm660-bimc";
607607
reg = <0x01008000 0x78000>;
608608
#interconnect-cells = <1>;
609-
clock-names = "bus", "bus_a";
610-
clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
611-
<&rpmcc RPM_SMD_BIMC_A_CLK>;
612609
};
613610

614611
restart@10ac000 {
@@ -620,28 +617,17 @@
620617
compatible = "qcom,sdm660-cnoc";
621618
reg = <0x01500000 0x10000>;
622619
#interconnect-cells = <1>;
623-
clock-names = "bus", "bus_a";
624-
clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
625-
<&rpmcc RPM_SMD_CNOC_A_CLK>;
626620
};
627621

628622
snoc: interconnect@1626000 {
629623
compatible = "qcom,sdm660-snoc";
630624
reg = <0x01626000 0x7090>;
631625
#interconnect-cells = <1>;
632-
clock-names = "bus", "bus_a";
633-
clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
634-
<&rpmcc RPM_SMD_SNOC_A_CLK>;
635626
};
636627

637628
anoc2_smmu: iommu@16c0000 {
638629
compatible = "qcom,sdm630-smmu-v2", "qcom,smmu-v2";
639630
reg = <0x016c0000 0x40000>;
640-
641-
assigned-clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
642-
assigned-clock-rates = <1000>;
643-
clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
644-
clock-names = "bus";
645631
#global-interrupts = <2>;
646632
#iommu-cells = <1>;
647633

@@ -686,16 +672,12 @@
686672
compatible = "qcom,sdm660-a2noc";
687673
reg = <0x01704000 0xc100>;
688674
#interconnect-cells = <1>;
689-
clock-names = "bus",
690-
"bus_a",
691-
"ipa",
675+
clock-names = "ipa",
692676
"ufs_axi",
693677
"aggre2_ufs_axi",
694678
"aggre2_usb3_axi",
695679
"cfg_noc_usb2_axi";
696-
clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>,
697-
<&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>,
698-
<&rpmcc RPM_SMD_IPA_CLK>,
680+
clocks = <&rpmcc RPM_SMD_IPA_CLK>,
699681
<&gcc GCC_UFS_AXI_CLK>,
700682
<&gcc GCC_AGGRE2_UFS_AXI_CLK>,
701683
<&gcc GCC_AGGRE2_USB3_AXI_CLK>,
@@ -706,10 +688,8 @@
706688
compatible = "qcom,sdm660-mnoc";
707689
reg = <0x01745000 0xa010>;
708690
#interconnect-cells = <1>;
709-
clock-names = "bus", "bus_a", "iface";
710-
clocks = <&rpmcc RPM_SMD_MMSSNOC_AXI_CLK>,
711-
<&rpmcc RPM_SMD_MMSSNOC_AXI_CLK_A>,
712-
<&mmcc AHB_CLK_SRC>;
691+
clock-names = "iface";
692+
clocks = <&mmcc AHB_CLK_SRC>;
713693
};
714694

715695
tsens: thermal-sensor@10ae000 {
@@ -1186,7 +1166,9 @@
11861166
clocks = <&gcc GCC_GPU_CFG_AHB_CLK>,
11871167
<&gcc GCC_BIMC_GFX_CLK>,
11881168
<&gcc GCC_GPU_BIMC_GFX_CLK>;
1189-
clock-names = "iface", "mem", "mem_iface";
1169+
clock-names = "iface",
1170+
"mem",
1171+
"mem_iface";
11901172
#global-interrupts = <2>;
11911173
#iommu-cells = <1>;
11921174

@@ -1288,20 +1270,16 @@
12881270
<&gcc GCC_USB30_MASTER_CLK>,
12891271
<&gcc GCC_AGGRE2_USB3_AXI_CLK>,
12901272
<&gcc GCC_USB30_SLEEP_CLK>,
1291-
<&gcc GCC_USB30_MOCK_UTMI_CLK>,
1292-
<&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
1273+
<&gcc GCC_USB30_MOCK_UTMI_CLK>;
12931274
clock-names = "cfg_noc",
12941275
"core",
12951276
"iface",
12961277
"sleep",
1297-
"mock_utmi",
1298-
"bus";
1278+
"mock_utmi";
12991279

13001280
assigned-clocks = <&gcc GCC_USB30_MOCK_UTMI_CLK>,
1301-
<&gcc GCC_USB30_MASTER_CLK>,
1302-
<&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
1303-
assigned-clock-rates = <19200000>, <120000000>,
1304-
<19200000>;
1281+
<&gcc GCC_USB30_MASTER_CLK>;
1282+
assigned-clock-rates = <19200000>, <120000000>;
13051283

13061284
interrupts = <GIC_SPI 347 IRQ_TYPE_LEVEL_HIGH>,
13071285
<GIC_SPI 243 IRQ_TYPE_LEVEL_HIGH>;
@@ -2204,10 +2182,9 @@
22042182

22052183
clocks = <&mmcc MNOC_AHB_CLK>,
22062184
<&mmcc BIMC_SMMU_AHB_CLK>,
2207-
<&rpmcc RPM_SMD_MMSSNOC_AXI_CLK>,
22082185
<&mmcc BIMC_SMMU_AXI_CLK>;
22092186
clock-names = "iface-mm", "iface-smmu",
2210-
"bus-mm", "bus-smmu";
2187+
"bus-smmu";
22112188
#global-interrupts = <2>;
22122189
#iommu-cells = <1>;
22132190

@@ -2324,12 +2301,6 @@
23242301
compatible = "qcom,sdm660-gnoc";
23252302
reg = <0x17900000 0xe000>;
23262303
#interconnect-cells = <1>;
2327-
/*
2328-
* This one apparently features no clocks,
2329-
* so let's not mess with the driver needlessly
2330-
*/
2331-
clock-names = "bus", "bus_a";
2332-
clocks = <&xo_board>, <&xo_board>;
23332304
};
23342305

23352306
apcs_glb: mailbox@17911000 {

0 commit comments

Comments
 (0)