Skip to content

Commit 283bab9

Browse files
Tony W Wang-ocsuryasaimadhu
authored andcommitted
x86/cpu: Remove redundant cpu_detect_cache_sizes() call
Both functions call init_intel_cacheinfo() which computes L2 and L3 cache sizes from CPUID(4). But then they also call cpu_detect_cache_sizes() a bit later which computes ->x86_tlbsize and L2 size from CPUID(80000006). However, the latter call is not needed because - on these CPUs, CPUID(80000006).EBX for ->x86_tlbsize is reserved - CPUID(80000006).ECX for the L2 size has the same result as CPUID(4) Therefore, remove the latter call to simplify the code. [ bp: Rewrite commit message. ] Signed-off-by: Tony W Wang-oc <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent bb02e2c commit 283bab9

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

arch/x86/kernel/cpu/centaur.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ static void init_c3(struct cpuinfo_x86 *c)
6464
c->x86_cache_alignment = c->x86_clflush_size * 2;
6565
set_cpu_cap(c, X86_FEATURE_REP_GOOD);
6666
}
67-
68-
cpu_detect_cache_sizes(c);
6967
}
7068

7169
enum {

arch/x86/kernel/cpu/zhaoxin.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ static void init_zhaoxin_cap(struct cpuinfo_x86 *c)
5151

5252
if (c->x86 >= 0x6)
5353
set_cpu_cap(c, X86_FEATURE_REP_GOOD);
54-
55-
cpu_detect_cache_sizes(c);
5654
}
5755

5856
static void early_init_zhaoxin(struct cpuinfo_x86 *c)

0 commit comments

Comments
 (0)