Skip to content

Commit 2848df9

Browse files
committed
wifi: iwlwifi: mvm: align UATS naming with firmware
The firmware has different names for this, which is confusing as even the convention of having the firmware name in a comment after the struct definition wasn't met here. Fix the naming, but keep UATS in some of it since that's the BIOS name. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://msgid.link/20240506095953.b0dfe17d5f44.I8f5f5a831c7b934ce3140f838315827c018103bb@changeid Signed-off-by: Johannes Berg <[email protected]>
1 parent 126ec41 commit 2848df9

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

drivers/net/wireless/intel/iwlwifi/fw/api/nvm-reg.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ enum iwl_regulatory_and_nvm_subcmd_ids {
4646
SAR_OFFSET_MAPPING_TABLE_CMD = 0x4,
4747

4848
/**
49-
* @UATS_TABLE_CMD: &struct iwl_uats_table_cmd
49+
* @MCC_ALLOWED_AP_TYPE_CMD: &struct iwl_mcc_allowed_ap_type_cmd
5050
*/
51-
UATS_TABLE_CMD = 0x5,
51+
MCC_ALLOWED_AP_TYPE_CMD = 0x5,
5252

5353
/**
5454
* @PNVM_INIT_COMPLETE_NTFY: &struct iwl_pnvm_init_complete_ntfy
@@ -701,13 +701,13 @@ struct iwl_pnvm_init_complete_ntfy {
701701
#define UATS_TABLE_COL_SIZE 13
702702

703703
/**
704-
* struct iwl_uats_table_cmd - struct for UATS_TABLE_CMD
704+
* struct iwl_mcc_allowed_ap_type_cmd - struct for MCC_ALLOWED_AP_TYPE_CMD
705705
* @offset_map: mapping a mcc to UHB AP type support (UATS) allowed
706706
* @reserved: reserved
707707
*/
708-
struct iwl_uats_table_cmd {
708+
struct iwl_mcc_allowed_ap_type_cmd {
709709
u8 offset_map[UATS_TABLE_ROW_SIZE][UATS_TABLE_COL_SIZE];
710710
__le16 reserved;
711-
} __packed; /* UATS_TABLE_CMD_S_VER_1 */
711+
} __packed; /* MCC_ALLOWED_AP_TYPE_CMD_API_S_VER_1 */
712712

713713
#endif /* __iwl_fw_api_nvm_reg_h__ */

drivers/net/wireless/intel/iwlwifi/fw/runtime.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ struct iwl_fw_runtime {
182182
u8 ppag_ver;
183183
struct iwl_sar_offset_mapping_cmd sgom_table;
184184
bool sgom_enabled;
185-
struct iwl_uats_table_cmd uats_table;
185+
struct iwl_mcc_allowed_ap_type_cmd uats_table;
186186
u8 uefi_tables_lock_status;
187187
bool uats_enabled;
188188
};

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ static void iwl_mvm_uats_init(struct iwl_mvm *mvm)
494494
int ret;
495495
struct iwl_host_cmd cmd = {
496496
.id = WIDE_ID(REGULATORY_AND_NVM_GROUP,
497-
UATS_TABLE_CMD),
497+
MCC_ALLOWED_AP_TYPE_CMD),
498498
.flags = 0,
499499
.data[0] = &mvm->fwrt.uats_table,
500500
.len[0] = sizeof(mvm->fwrt.uats_table),
@@ -516,7 +516,7 @@ static void iwl_mvm_uats_init(struct iwl_mvm *mvm)
516516
IWL_FW_CMD_VER_UNKNOWN);
517517
if (cmd_ver != 1) {
518518
IWL_DEBUG_RADIO(mvm,
519-
"UATS_TABLE_CMD ver %d not supported\n",
519+
"MCC_ALLOWED_AP_TYPE_CMD ver %d not supported\n",
520520
cmd_ver);
521521
return;
522522
}
@@ -529,9 +529,10 @@ static void iwl_mvm_uats_init(struct iwl_mvm *mvm)
529529

530530
ret = iwl_mvm_send_cmd(mvm, &cmd);
531531
if (ret < 0)
532-
IWL_ERR(mvm, "failed to send UATS_TABLE_CMD (%d)\n", ret);
532+
IWL_ERR(mvm, "failed to send MCC_ALLOWED_AP_TYPE_CMD (%d)\n",
533+
ret);
533534
else
534-
IWL_DEBUG_RADIO(mvm, "UATS_TABLE_CMD sent to FW\n");
535+
IWL_DEBUG_RADIO(mvm, "MCC_ALLOWED_AP_TYPE_CMD sent to FW\n");
535536
}
536537

537538
static int iwl_mvm_sgom_init(struct iwl_mvm *mvm)

0 commit comments

Comments
 (0)