Skip to content

Commit 284d2b4

Browse files
brooniewilldeacon
authored andcommitted
kselftest/arm64: Use preferred form for predicate load/stores
The preferred form of the str/ldr for predicate registers with an immediate of zero is to omit the zero, and the clang built in assembler rejects the zero immediate. Drop the immediate. Signed-off-by: Mark Brown <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent a75df5b commit 284d2b4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/arm64/abi/syscall-abi-asm.S

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ do_syscall:
153153
// Only set a non-zero FFR, test patterns must be zero since the
154154
// syscall should clear it - this lets us handle FA64.
155155
ldr x2, =ffr_in
156-
ldr p0, [x2, #0]
156+
ldr p0, [x2]
157157
ldr x2, [x2, #0]
158158
cbz x2, 2f
159159
wrffr p0.b
@@ -298,7 +298,7 @@ do_syscall:
298298
cbz x2, 1f
299299
ldr x2, =ffr_out
300300
rdffr p0.b
301-
str p0, [x2, #0]
301+
str p0, [x2]
302302
1:
303303

304304
// Restore callee saved registers x19-x30

0 commit comments

Comments
 (0)