Skip to content

Commit 286ed19

Browse files
diederikdehaasMani-Sadhasivam
authored andcommitted
PCI: dw-rockchip: Fix PHY function call sequence in rockchip_pcie_phy_deinit()
The documentation for the phy_power_off() function explicitly says that it must be called before phy_exit(). Hence, follow the same rule in rockchip_pcie_phy_deinit(). Fixes: 0e898eb ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver") Signed-off-by: Diederik de Haas <[email protected]> [mani: commit message change] Signed-off-by: Manivannan Sadhasivam <[email protected]> Reviewed-by: Niklas Cassel <[email protected]> Reviewed-by: Dragan Simic <[email protected]> Acked-by: Shawn Lin <[email protected]> Cc: [email protected] # v5.15+ Link: https://patch.msgid.link/[email protected]
1 parent 5e5a3bf commit 286ed19

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/controller/dwc/pcie-dw-rockchip.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,8 +431,8 @@ static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip)
431431

432432
static void rockchip_pcie_phy_deinit(struct rockchip_pcie *rockchip)
433433
{
434-
phy_exit(rockchip->phy);
435434
phy_power_off(rockchip->phy);
435+
phy_exit(rockchip->phy);
436436
}
437437

438438
static const struct dw_pcie_ops dw_pcie_ops = {

0 commit comments

Comments
 (0)