Skip to content

Commit 28717ec

Browse files
passgatstorulf
authored andcommitted
pmdomain: imx93-pd: don't unprepare clocks on driver remove
The removed code was added to handle the case where the power domain is already on during the driver's probing. In this use case, the "is_off" parameter is passed as false to pm_genpd_init() to inform it not to call the power_on() callback, as it's unnecessary to perform the hardware power-on procedure since the power domain is already on. Therefore, with the call to clk_bulk_prepare_enable() by probe(), the system is in the same operational state as when "is_off" is passed as true after the power_on() callback execution: probe() -> is_off == true -> clk_bulk_prepare_enable() called by power_on() probe() -> is_off == false -> clk_bulk_prepare_enable() called by probe() Reaching the same logical and operational state, it follows that upon driver removal, there is no need to perform different actions depending on the power domain's on/off state during probing. Signed-off-by: Dario Binacchi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ulf Hansson <[email protected]>
1 parent 06cee3c commit 28717ec

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/pmdomain/imx/imx93-pd.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,6 @@ static void imx93_pd_remove(struct platform_device *pdev)
9090
struct device *dev = &pdev->dev;
9191
struct device_node *np = dev->of_node;
9292

93-
if (!domain->init_off)
94-
clk_bulk_disable_unprepare(domain->num_clks, domain->clks);
95-
9693
of_genpd_del_provider(np);
9794
pm_genpd_remove(&domain->genpd);
9895
}

0 commit comments

Comments
 (0)