Skip to content

Commit 289de35

Browse files
vingu-linaroIngo Molnar
authored andcommitted
sched/fair: Fix statistics for find_idlest_group()
sgs->group_weight is not set while gathering statistics in update_sg_wakeup_stats(). This means that a group can be classified as fully busy with 0 running tasks if utilization is high enough. This path is mainly used for fork and exec. Fixes: 57abff0 ("sched/fair: Rework find_idlest_group()") Signed-off-by: Vincent Guittot <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Acked-by: Peter Zijlstra <[email protected]> Acked-by: Mel Gorman <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent c5f8689 commit 289de35

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

kernel/sched/fair.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8337,6 +8337,8 @@ static inline void update_sg_wakeup_stats(struct sched_domain *sd,
83378337

83388338
sgs->group_capacity = group->sgc->capacity;
83398339

8340+
sgs->group_weight = group->group_weight;
8341+
83408342
sgs->group_type = group_classify(sd->imbalance_pct, group, sgs);
83418343

83428344
/*

0 commit comments

Comments
 (0)