Skip to content

Commit 28cb138

Browse files
Jakob-Koschelgregkh
authored andcommitted
vt_ioctl: add array_index_nospec to VT_ACTIVATE
in vt_setactivate an almost identical code path has been patched with array_index_nospec. In the VT_ACTIVATE path the user input is from a system call argument instead of a usercopy. For consistency both code paths should have the same mitigations applied. Kasper Acknowledgements: Jakob Koschel, Brian Johannesmeyer, Kaveh Razavi, Herbert Bos, Cristiano Giuffrida from the VUSec group at VU Amsterdam. Co-developed-by: Brian Johannesmeyer <[email protected]> Signed-off-by: Brian Johannesmeyer <[email protected]> Signed-off-by: Jakob Koschel <[email protected]> Link: https://lore.kernel.org/r/[email protected] Cc: stable <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 61cc70d commit 28cb138

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/tty/vt/vt_ioctl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -845,6 +845,7 @@ int vt_ioctl(struct tty_struct *tty,
845845
return -ENXIO;
846846

847847
arg--;
848+
arg = array_index_nospec(arg, MAX_NR_CONSOLES);
848849
console_lock();
849850
ret = vc_allocate(arg);
850851
console_unlock();

0 commit comments

Comments
 (0)