Skip to content

Commit 29ca3b3

Browse files
Gateworksdavem330
authored andcommitted
net: thunderx: use proper interface type for RGMII
The configuration of the OCTEONTX XCV_DLL_CTL register via xcv_init_hw() is such that the RGMII RX delay is bypassed leaving the RGMII TX delay enabled in the MAC: /* Configure DLL - enable or bypass * TX no bypass, RX bypass */ cfg = readq_relaxed(xcv->reg_base + XCV_DLL_CTL); cfg &= ~0xFF03; cfg |= CLKRX_BYP; writeq_relaxed(cfg, xcv->reg_base + XCV_DLL_CTL); This would coorespond to a interface type of PHY_INTERFACE_MODE_RGMII_RXID and not PHY_INTERFACE_MODE_RGMII. Fixing this allows RGMII PHY drivers to do the right thing (enable RX delay in the PHY) instead of erroneously enabling both delays in the PHY. Signed-off-by: Tim Harvey <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c76b305 commit 29ca3b3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/cavium/thunder/thunder_bgx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1039,7 +1039,7 @@ static int phy_interface_mode(u8 lmac_type)
10391039
if (lmac_type == BGX_MODE_QSGMII)
10401040
return PHY_INTERFACE_MODE_QSGMII;
10411041
if (lmac_type == BGX_MODE_RGMII)
1042-
return PHY_INTERFACE_MODE_RGMII;
1042+
return PHY_INTERFACE_MODE_RGMII_RXID;
10431043

10441044
return PHY_INTERFACE_MODE_SGMII;
10451045
}

0 commit comments

Comments
 (0)