Skip to content

Commit 29ed2b5

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: compress: don't allow unaligned truncation on released compress inode
f2fs image may be corrupted after below testcase: - mkfs.f2fs -O extra_attr,compression -f /dev/vdb - mount /dev/vdb /mnt/f2fs - touch /mnt/f2fs/file - f2fs_io setflags compression /mnt/f2fs/file - dd if=/dev/zero of=/mnt/f2fs/file bs=4k count=4 - f2fs_io release_cblocks /mnt/f2fs/file - truncate -s 8192 /mnt/f2fs/file - umount /mnt/f2fs - fsck.f2fs /dev/vdb [ASSERT] (fsck_chk_inode_blk:1256) --> ino: 0x5 has i_blocks: 0x00000002, but has 0x3 blocks [FSCK] valid_block_count matching with CP [Fail] [0x4, 0x5] [FSCK] other corrupted bugs [Fail] The reason is: partial truncation assume compressed inode has reserved blocks, after partial truncation, valid block count may change w/o .i_blocks and .total_valid_block_count update, result in corruption. This patch only allow cluster size aligned truncation on released compress inode for fixing. Fixes: c614041 ("f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit") Signed-off-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 0fa4e57 commit 29ed2b5

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

fs/f2fs/file.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -952,9 +952,14 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
952952
ATTR_GID | ATTR_TIMES_SET))))
953953
return -EPERM;
954954

955-
if ((attr->ia_valid & ATTR_SIZE) &&
956-
!f2fs_is_compress_backend_ready(inode))
957-
return -EOPNOTSUPP;
955+
if ((attr->ia_valid & ATTR_SIZE)) {
956+
if (!f2fs_is_compress_backend_ready(inode))
957+
return -EOPNOTSUPP;
958+
if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED) &&
959+
!IS_ALIGNED(attr->ia_size,
960+
F2FS_BLK_TO_BYTES(F2FS_I(inode)->i_cluster_size)))
961+
return -EINVAL;
962+
}
958963

959964
err = setattr_prepare(idmap, dentry, attr);
960965
if (err)

0 commit comments

Comments
 (0)