Skip to content

Commit 2a0b128

Browse files
mmhaldwmw2
authored andcommitted
KVM: Clean up hva_to_pfn_retry()
Make hva_to_pfn_retry() use kvm instance cached in gfn_to_pfn_cache. Suggested-by: Sean Christopherson <[email protected]> Signed-off-by: Michal Luczaj <[email protected]> Signed-off-by: Sean Christopherson <[email protected]> Signed-off-by: David Woodhouse <[email protected]>
1 parent e308c24 commit 2a0b128

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

virt/kvm/pfncache.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ static inline bool mmu_notifier_retry_cache(struct kvm *kvm, unsigned long mmu_s
138138
return kvm->mmu_invalidate_seq != mmu_seq;
139139
}
140140

141-
static kvm_pfn_t hva_to_pfn_retry(struct kvm *kvm, struct gfn_to_pfn_cache *gpc)
141+
static kvm_pfn_t hva_to_pfn_retry(struct gfn_to_pfn_cache *gpc)
142142
{
143143
/* Note, the new page offset may be different than the old! */
144144
void *old_khva = gpc->khva - offset_in_page(gpc->khva);
@@ -158,7 +158,7 @@ static kvm_pfn_t hva_to_pfn_retry(struct kvm *kvm, struct gfn_to_pfn_cache *gpc)
158158
gpc->valid = false;
159159

160160
do {
161-
mmu_seq = kvm->mmu_invalidate_seq;
161+
mmu_seq = gpc->kvm->mmu_invalidate_seq;
162162
smp_rmb();
163163

164164
write_unlock_irq(&gpc->lock);
@@ -216,7 +216,7 @@ static kvm_pfn_t hva_to_pfn_retry(struct kvm *kvm, struct gfn_to_pfn_cache *gpc)
216216
* attempting to refresh.
217217
*/
218218
WARN_ON_ONCE(gpc->valid);
219-
} while (mmu_notifier_retry_cache(kvm, mmu_seq));
219+
} while (mmu_notifier_retry_cache(gpc->kvm, mmu_seq));
220220

221221
gpc->valid = true;
222222
gpc->pfn = new_pfn;
@@ -294,7 +294,7 @@ int kvm_gpc_refresh(struct kvm *kvm, struct gfn_to_pfn_cache *gpc, gpa_t gpa,
294294
* drop the lock and do the HVA to PFN lookup again.
295295
*/
296296
if (!gpc->valid || old_uhva != gpc->uhva) {
297-
ret = hva_to_pfn_retry(kvm, gpc);
297+
ret = hva_to_pfn_retry(gpc);
298298
} else {
299299
/*
300300
* If the HVA→PFN mapping was already valid, don't unmap it.

0 commit comments

Comments
 (0)