Skip to content

Commit 2a48b37

Browse files
committed
Merge tag 'auxdisplay-for-linus-v5.6-rc6' of git://github.com/ojeda/linux
Pull auxdisplay updates from Miguel Ojeda: "A few minor auxdisplay improvements: - charlcd: replace zero-length array with flexible-array member (kernel-wide cleanup by Gustavo A. R. Silva) - img-ascii-lcd: convert to devm_platform_ioremap_resource (Yangtao Li) - Fix Kconfig indentation (Krzysztof Kozlowski) * tag 'auxdisplay-for-linus-v5.6-rc6' of git://github.com/ojeda/linux: auxdisplay: charlcd: replace zero-length array with flexible-array member auxdisplay: img-ascii-lcd: convert to devm_platform_ioremap_resource auxdisplay: Fix Kconfig indentation
2 parents e941484 + 2f920c0 commit 2a48b37

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

drivers/auxdisplay/Kconfig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ config CFAG12864B
111111
If unsure, say N.
112112

113113
config CFAG12864B_RATE
114-
int "Refresh rate (hertz)"
114+
int "Refresh rate (hertz)"
115115
depends on CFAG12864B
116116
default "20"
117117
---help---
@@ -329,7 +329,7 @@ config PANEL_LCD_PROTO
329329

330330
config PANEL_LCD_PIN_E
331331
depends on PANEL_PROFILE="0" && PANEL_LCD="1" && PANEL_LCD_PROTO="0"
332-
int "Parallel port pin number & polarity connected to the LCD E signal (-17...17) "
332+
int "Parallel port pin number & polarity connected to the LCD E signal (-17...17) "
333333
range -17 17
334334
default 14
335335
---help---
@@ -344,7 +344,7 @@ config PANEL_LCD_PIN_E
344344

345345
config PANEL_LCD_PIN_RS
346346
depends on PANEL_PROFILE="0" && PANEL_LCD="1" && PANEL_LCD_PROTO="0"
347-
int "Parallel port pin number & polarity connected to the LCD RS signal (-17...17) "
347+
int "Parallel port pin number & polarity connected to the LCD RS signal (-17...17) "
348348
range -17 17
349349
default 17
350350
---help---
@@ -359,7 +359,7 @@ config PANEL_LCD_PIN_RS
359359

360360
config PANEL_LCD_PIN_RW
361361
depends on PANEL_PROFILE="0" && PANEL_LCD="1" && PANEL_LCD_PROTO="0"
362-
int "Parallel port pin number & polarity connected to the LCD RW signal (-17...17) "
362+
int "Parallel port pin number & polarity connected to the LCD RW signal (-17...17) "
363363
range -17 17
364364
default 16
365365
---help---
@@ -374,7 +374,7 @@ config PANEL_LCD_PIN_RW
374374

375375
config PANEL_LCD_PIN_SCL
376376
depends on PANEL_PROFILE="0" && PANEL_LCD="1" && PANEL_LCD_PROTO!="0"
377-
int "Parallel port pin number & polarity connected to the LCD SCL signal (-17...17) "
377+
int "Parallel port pin number & polarity connected to the LCD SCL signal (-17...17) "
378378
range -17 17
379379
default 1
380380
---help---
@@ -389,7 +389,7 @@ config PANEL_LCD_PIN_SCL
389389

390390
config PANEL_LCD_PIN_SDA
391391
depends on PANEL_PROFILE="0" && PANEL_LCD="1" && PANEL_LCD_PROTO!="0"
392-
int "Parallel port pin number & polarity connected to the LCD SDA signal (-17...17) "
392+
int "Parallel port pin number & polarity connected to the LCD SDA signal (-17...17) "
393393
range -17 17
394394
default 2
395395
---help---
@@ -404,12 +404,12 @@ config PANEL_LCD_PIN_SDA
404404

405405
config PANEL_LCD_PIN_BL
406406
depends on PANEL_PROFILE="0" && PANEL_LCD="1"
407-
int "Parallel port pin number & polarity connected to the LCD backlight signal (-17...17) "
407+
int "Parallel port pin number & polarity connected to the LCD backlight signal (-17...17) "
408408
range -17 17
409409
default 0
410410
---help---
411411
This describes the number of the parallel port pin to which the LCD 'BL' signal
412-
has been connected. It can be :
412+
has been connected. It can be :
413413

414414
0 : no connection (eg: connected to ground)
415415
1..17 : directly connected to any of these pins on the DB25 plug

drivers/auxdisplay/charlcd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ struct charlcd_priv {
8888
int len;
8989
} esc_seq;
9090

91-
unsigned long long drvdata[0];
91+
unsigned long long drvdata[];
9292
};
9393

9494
#define charlcd_to_priv(p) container_of(p, struct charlcd_priv, lcd)

drivers/auxdisplay/img-ascii-lcd.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ static int img_ascii_lcd_probe(struct platform_device *pdev)
356356
const struct of_device_id *match;
357357
const struct img_ascii_lcd_config *cfg;
358358
struct img_ascii_lcd_ctx *ctx;
359-
struct resource *res;
360359
int err;
361360

362361
match = of_match_device(img_ascii_lcd_matches, &pdev->dev);
@@ -378,8 +377,7 @@ static int img_ascii_lcd_probe(struct platform_device *pdev)
378377
&ctx->offset))
379378
return -EINVAL;
380379
} else {
381-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
382-
ctx->base = devm_ioremap_resource(&pdev->dev, res);
380+
ctx->base = devm_platform_ioremap_resource(pdev, 0);
383381
if (IS_ERR(ctx->base))
384382
return PTR_ERR(ctx->base);
385383
}

0 commit comments

Comments
 (0)