Skip to content

Commit 2a5e6f7

Browse files
digetxlinusw
authored andcommitted
gpio: max77620: Fix missing release of interrupt
The requested interrupt is never released by the driver. Fix this by using the resource-managed variant of request_threaded_irq(). Fixes: ab3dd9c ("gpio: max77620: Fix interrupt handling") Signed-off-by: Dmitry Osipenko <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Acked-by: Laxman Dewangan <[email protected]> Cc: <[email protected]> # 5.5+ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 4ee8225 commit 2a5e6f7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpio/gpio-max77620.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,9 @@ static int max77620_gpio_probe(struct platform_device *pdev)
305305
gpiochip_irqchip_add_nested(&mgpio->gpio_chip, &max77620_gpio_irqchip,
306306
0, handle_edge_irq, IRQ_TYPE_NONE);
307307

308-
ret = request_threaded_irq(gpio_irq, NULL, max77620_gpio_irqhandler,
309-
IRQF_ONESHOT, "max77620-gpio", mgpio);
308+
ret = devm_request_threaded_irq(&pdev->dev, gpio_irq, NULL,
309+
max77620_gpio_irqhandler, IRQF_ONESHOT,
310+
"max77620-gpio", mgpio);
310311
if (ret < 0) {
311312
dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret);
312313
return ret;

0 commit comments

Comments
 (0)