Skip to content

Commit 2aad93b

Browse files
bastien-curutchetlag-linaro
authored andcommitted
leds: pca9532: Remove irrelevant blink configuration error message
The update_hw_blink() function prints an error message when hardware is not able to handle a blink configuration on its own. IMHO, this isn't a 'real' error since the software fallback is used afterwards. Remove the error messages to avoid flooding the logs with unnecessary messages. Cc: [email protected] Fixes: 48ca7f3 ("leds: pca9532: Use PWM1 for hardware blinking") Signed-off-by: Bastien Curutchet <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lee Jones <[email protected]>
1 parent 045391a commit 2aad93b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/leds/leds-pca9532.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,16 +215,15 @@ static int pca9532_update_hw_blink(struct pca9532_led *led,
215215
if (other->state == PCA9532_PWM1) {
216216
if (other->ldev.blink_delay_on != delay_on ||
217217
other->ldev.blink_delay_off != delay_off) {
218-
dev_err(&led->client->dev,
219-
"HW can handle only one blink configuration at a time\n");
218+
/* HW can handle only one blink configuration at a time */
220219
return -EINVAL;
221220
}
222221
}
223222
}
224223

225224
psc = ((delay_on + delay_off) * PCA9532_PWM_PERIOD_DIV - 1) / 1000;
226225
if (psc > U8_MAX) {
227-
dev_err(&led->client->dev, "Blink period too long to be handled by hardware\n");
226+
/* Blink period too long to be handled by hardware */
228227
return -EINVAL;
229228
}
230229

0 commit comments

Comments
 (0)