Skip to content

Commit 2ac6c4a

Browse files
aford173Shawn Guo
authored andcommitted
arm64: dts: imx8mn: Fix video clock parents
There are a few clocks whose parents are set in mipi_dsi and mxsfb nodes, but these clocks are used by the disp_blk_ctrl power domain which may cause an issue when re-parenting, resuling in a disp_pixel clock having the wrong parent and wrong rate. Fix this by moving the assigned-clock-parents as associate clock assignments to the power-domain node to setup these clocks before they are enabled. Fixes: d825fb6 ("arm64: dts: imx8mn: Add display pipeline components") Signed-off-by: Adam Ford <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent ac9a786 commit 2ac6c4a

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

arch/arm64/boot/dts/freescale/imx8mn.dtsi

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1069,13 +1069,6 @@
10691069
<&clk IMX8MN_CLK_DISP_APB_ROOT>,
10701070
<&clk IMX8MN_CLK_DISP_AXI_ROOT>;
10711071
clock-names = "pix", "axi", "disp_axi";
1072-
assigned-clocks = <&clk IMX8MN_CLK_DISP_PIXEL_ROOT>,
1073-
<&clk IMX8MN_CLK_DISP_AXI>,
1074-
<&clk IMX8MN_CLK_DISP_APB>;
1075-
assigned-clock-parents = <&clk IMX8MN_CLK_DISP_PIXEL>,
1076-
<&clk IMX8MN_SYS_PLL2_1000M>,
1077-
<&clk IMX8MN_SYS_PLL1_800M>;
1078-
assigned-clock-rates = <594000000>, <500000000>, <200000000>;
10791072
interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
10801073
power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_LCDIF>;
10811074
status = "disabled";
@@ -1093,12 +1086,6 @@
10931086
clocks = <&clk IMX8MN_CLK_DSI_CORE>,
10941087
<&clk IMX8MN_CLK_DSI_PHY_REF>;
10951088
clock-names = "bus_clk", "sclk_mipi";
1096-
assigned-clocks = <&clk IMX8MN_CLK_DSI_CORE>,
1097-
<&clk IMX8MN_CLK_DSI_PHY_REF>;
1098-
assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_266M>,
1099-
<&clk IMX8MN_CLK_24M>;
1100-
assigned-clock-rates = <266000000>, <24000000>;
1101-
samsung,pll-clock-frequency = <24000000>;
11021089
interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
11031090
power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_MIPI_DSI>;
11041091
status = "disabled";
@@ -1142,6 +1129,21 @@
11421129
"lcdif-axi", "lcdif-apb", "lcdif-pix",
11431130
"dsi-pclk", "dsi-ref",
11441131
"csi-aclk", "csi-pclk";
1132+
assigned-clocks = <&clk IMX8MN_CLK_DSI_CORE>,
1133+
<&clk IMX8MN_CLK_DSI_PHY_REF>,
1134+
<&clk IMX8MN_CLK_DISP_PIXEL>,
1135+
<&clk IMX8MN_CLK_DISP_AXI>,
1136+
<&clk IMX8MN_CLK_DISP_APB>;
1137+
assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_266M>,
1138+
<&clk IMX8MN_CLK_24M>,
1139+
<&clk IMX8MN_VIDEO_PLL1_OUT>,
1140+
<&clk IMX8MN_SYS_PLL2_1000M>,
1141+
<&clk IMX8MN_SYS_PLL1_800M>;
1142+
assigned-clock-rates = <266000000>,
1143+
<24000000>,
1144+
<594000000>,
1145+
<500000000>,
1146+
<200000000>;
11451147
#power-domain-cells = <1>;
11461148
};
11471149

0 commit comments

Comments
 (0)