Skip to content

Commit 2adaec4

Browse files
spandruvadaandy-shev
authored andcommitted
platform/x86: ISST: Increase timeout
Fix timeout issue on some Ice Lake servers, where mail box command is timing out before the response, Signed-off-by: Srinivas Pandruvada <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
1 parent f441d66 commit 2adaec4

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

drivers/platform/x86/intel_speed_select_if/isst_if_mbox_pci.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,12 @@
2121
#define PUNIT_MAILBOX_BUSY_BIT 31
2222

2323
/*
24-
* Commands has variable amount of processing time. Most of the commands will
25-
* be done in 0-3 tries, but some takes up to 50.
26-
* The real processing time was observed as 25us for the most of the commands
27-
* at 2GHz. It is possible to optimize this count taking samples on customer
28-
* systems.
24+
* The average time to complete some commands is about 40us. The current
25+
* count is enough to satisfy 40us. But when the firmware is very busy, this
26+
* causes timeout occasionally. So increase to deal with some worst case
27+
* scenarios. Most of the command still complete in few us.
2928
*/
30-
#define OS_MAILBOX_RETRY_COUNT 50
29+
#define OS_MAILBOX_RETRY_COUNT 100
3130

3231
struct isst_if_device {
3332
struct mutex mutex;

0 commit comments

Comments
 (0)