Skip to content

Commit 2b938c3

Browse files
MarijnS95lumag
authored andcommitted
drm/msm/dpu: Always flush the slave INTF on the CTL
As we can clearly see in a downstream kernel [1], flushing the slave INTF is skipped /only if/ the PPSPLIT topology is active. However, when DPU was originally submitted to mainline PPSPLIT was no longer part of it (seems to have been ripped out before submission), but this clause was incorrectly ported from the original SDE driver. Given that there is no support for PPSPLIT (currently), flushing the slave INTF should /never/ be skipped (as the `if (ppsplit && !master) goto skip;` clause downstream never becomes true). [1]: https://git.codelinaro.org/clo/la/platform/vendor/opensource/display-drivers/-/blob/display-kernel.lnx.5.4.r1-rel/msm/sde/sde_encoder_phys_cmd.c?ref_type=heads#L1131-1139 Fixes: 25fdd59 ("drm/msm: Add SDM845 DPU support") Signed-off-by: Marijn Suijten <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/589901/ Link: https://lore.kernel.org/r/20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-3-78ae3ee9a697@somainline.org Signed-off-by: Dmitry Baryshkov <[email protected]>
1 parent f12e0e1 commit 2b938c3

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -448,9 +448,6 @@ static void dpu_encoder_phys_cmd_enable_helper(
448448

449449
_dpu_encoder_phys_cmd_pingpong_config(phys_enc);
450450

451-
if (!dpu_encoder_phys_cmd_is_master(phys_enc))
452-
return;
453-
454451
ctl = phys_enc->hw_ctl;
455452
ctl->ops.update_pending_flush_intf(ctl, phys_enc->hw_intf->idx);
456453
}

0 commit comments

Comments
 (0)