Skip to content

Commit 2bd02f5

Browse files
chewittSteven Price
authored andcommitted
drm/panfrost: fix power transition timeout warnings
Increase the timeout value to prevent system logs on Amlogic boards flooding with power transition warnings: [ 13.047638] panfrost ffe40000.gpu: shader power transition timeout [ 13.048674] panfrost ffe40000.gpu: l2 power transition timeout [ 13.937324] panfrost ffe40000.gpu: shader power transition timeout [ 13.938351] panfrost ffe40000.gpu: l2 power transition timeout ... [39829.506904] panfrost ffe40000.gpu: shader power transition timeout [39829.507938] panfrost ffe40000.gpu: l2 power transition timeout [39949.508369] panfrost ffe40000.gpu: shader power transition timeout [39949.509405] panfrost ffe40000.gpu: l2 power transition timeout The 2000 value has been found through trial and error testing with devices using G52 and G31 GPUs. Fixes: 22aa1a2 ("drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()") Signed-off-by: Christian Hewitt <[email protected]> Reviewed-by: Steven Price <[email protected]> Reviewed-by: AngeloGioacchino Del Regno <[email protected]> Signed-off-by: Steven Price <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent aba2a14 commit 2bd02f5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/gpu/drm/panfrost/panfrost_gpu.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -441,19 +441,19 @@ void panfrost_gpu_power_off(struct panfrost_device *pfdev)
441441

442442
gpu_write(pfdev, SHADER_PWROFF_LO, pfdev->features.shader_present);
443443
ret = readl_relaxed_poll_timeout(pfdev->iomem + SHADER_PWRTRANS_LO,
444-
val, !val, 1, 1000);
444+
val, !val, 1, 2000);
445445
if (ret)
446446
dev_err(pfdev->dev, "shader power transition timeout");
447447

448448
gpu_write(pfdev, TILER_PWROFF_LO, pfdev->features.tiler_present);
449449
ret = readl_relaxed_poll_timeout(pfdev->iomem + TILER_PWRTRANS_LO,
450-
val, !val, 1, 1000);
450+
val, !val, 1, 2000);
451451
if (ret)
452452
dev_err(pfdev->dev, "tiler power transition timeout");
453453

454454
gpu_write(pfdev, L2_PWROFF_LO, pfdev->features.l2_present);
455455
ret = readl_poll_timeout(pfdev->iomem + L2_PWRTRANS_LO,
456-
val, !val, 0, 1000);
456+
val, !val, 0, 2000);
457457
if (ret)
458458
dev_err(pfdev->dev, "l2 power transition timeout");
459459
}

0 commit comments

Comments
 (0)